874341 - Regressions for Mozmill tests for new Australis theme

Status: RESOLVED WONTFIX

(Mozilla QA Graveyard :: Mozmill Tests, defect)

Description

[Daniela Petrovici]

All functional runs failed because some of the Lookup expressions could not be found. The issue reproduced on Linux 12.04 x86:
http://mozmill-crowd.blargon7.com/#/functional/report/14f8bc4e22e61353662cded4c2f27626
MAC 10.7.5:
http://mozmill-crowd.blargon7.com/#/functional/report/14f8bc4e22e61353662cded4c2f2838e
Windows XP:
http://mozmill-crowd.blargon7.com/#/functional/report/14f8bc4e22e61353662cded4c2f27d00

Comment 1

[Henrik Skupin [:whimboo][⌚️UTC+2]]

This should be a meta tracking bug for all the existent failures. Please be sure to investigate individual failures in depth before filing additional bugs. Mark them all as blocking this bug.

Comment 2

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Builds for this new feature can be get from FTP:
http://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/latest-ux/

Comment 3

[Daniela Petrovici]

Attachment: patch v1.0

Tests fail due to the following reasons:
1) testPopupsBlocked - line that makes the test fail:
http://hg.mozilla.org/qa/mozmill-tests/file/05730582186d/lib/tabs.js#l22

TAB_BROWSER lookup expression needs to contain: '/id("content-deck")' element also. The line should be changed to:
const TABS_BROWSER = TABS_VIEW + '/id("content-deck")/id("browser")/id("appcontent")/id("content")';

2) /testSecurity/testSafeBrowsingNotificationBar.js - the above fix to the tabs.js library will also fix this test

3) /testAwesomeBar/testPasteLocationBar.js - fails due to line: http://hg.mozilla.org/qa/mozmill-tests/file/05730582186d/lib/toolbars.js#l18

URLBAR_CONTAINER needs to contain: 'id("nav-bar-customizationtarget")' since this is the element that contains the urlbar-container. The line should be changed to:
const URLBAR_CONTAINER = '/id("main-window")/id("tab-view-deck")/[0]' +
                         '/id("navigator-toolbox")/id("nav-bar")/id("nav-bar-customizationtarget")/id("urlbar-container")';

4) all the tests in testSearch folder fail due to this line: http://hg.mozilla.org/qa/mozmill-tests/file/05730582186d/lib/search.js#l26

SEARCH_BAR needs to contain: '/id("nav-bar-customizationtarget")' since this is the element that contains the search-container. The line should be changed to:
const SEARCH_BAR          = NAV_BAR + '/id("nav-bar-customizationtarget")/id("search-container")/id("searchbar")';

Reports on Linux, Windows and MAC show that these fixes will resolve most of the problems in the Australis builds. Issues that remain are:
- bug 793705 - reproducible with any builds, not just Australis
- bug 874344 - reproducible on Windows only

Reports:
http://mozmill-crowd.blargon7.com/#/functional/report/14f8bc4e22e61353662cded4c2fa1ada
http://mozmill-crowd.blargon7.com/#/functional/report/14f8bc4e22e61353662cded4c2fa0d1f
http://mozmill-crowd.blargon7.com/#/functional/report/14f8bc4e22e61353662cded4c2f9d05f

Comment 4

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Comment on attachment 752111 [details] [diff] [review]
patch v1.0

Review of attachment 752111 [details] [diff] [review]:
-----------------------------------------------------------------

f+ given that it seems to be the right approach. But please read my last comment and file individual bugs.

::: lib/search.js
@@ +22,5 @@
>  
>  // Helper lookup constants for the search bar elements
>  const NAV_BAR             = '/id("main-window")/id("tab-view-deck")/[0]' +
>                              '/id("navigator-toolbox")/id("nav-bar")';
> +const SEARCH_BAR          = NAV_BAR + '/id("nav-bar-customizationtarget")/id("search-container")/id("searchbar")';

I'm not that happy with all those changes. We might want to check that we can fully get rid of the lookup elements and use nodeCollector instead.

::: lib/tabs.js
@@ +18,5 @@
>  
>  const PREF_TABS_ANIMATE = "browser.tabs.animate";
>  
>  const TABS_VIEW = '/id("main-window")/id("tab-view-deck")/[0]';
> +const TABS_BROWSER = TABS_VIEW + '/id("content-deck")/id("browser")/id("appcontent")/id("content")';

You filed another bug for that issue, right?

Comment 5

[Daniela Petrovici]

(In reply to Henrik Skupin (:whimboo) from comment #4)
> Comment on attachment 752111 [details] [diff] [review]
> patch v1.0
> 
> Review of attachment 752111 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> f+ given that it seems to be the right approach. But please read my last
> comment and file individual bugs.

I have now logged: bug 874393, bug 874394 and bug 874395

> ::: lib/search.js
> @@ +22,5 @@
> >  
> >  // Helper lookup constants for the search bar elements
> >  const NAV_BAR             = '/id("main-window")/id("tab-view-deck")/[0]' +
> >                              '/id("navigator-toolbox")/id("nav-bar")';
> > +const SEARCH_BAR          = NAV_BAR + '/id("nav-bar-customizationtarget")/id("search-container")/id("searchbar")';
> 
> I'm not that happy with all those changes. We might want to check that we
> can fully get rid of the lookup elements and use nodeCollector instead.

I will investigate this as part of the dependent bugs before uploading a new patch for them

> ::: lib/tabs.js
> @@ +18,5 @@
> >  
> >  const PREF_TABS_ANIMATE = "browser.tabs.animate";
> >  
> >  const TABS_VIEW = '/id("main-window")/id("tab-view-deck")/[0]';
> > +const TABS_BROWSER = TABS_VIEW + '/id("content-deck")/id("browser")/id("appcontent")/id("content")';
> 
> You filed another bug for that issue, right?
No, bug 874344 seems to be a different issue from this one which I now logged in bug 874395

Comment 6

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Please figure out which of those changes are intentional and which might be bugs (regressions). Thanks.

Comment 7

[Henrik Skupin [:whimboo][⌚️UTC+2]]

We still have bug 503192 which is about getting rid of lookup and xpath expressions. Getting those dependent bugs fixed might help us a lot.

Comment 8

[Jonathan French (:jfrench)]

I've entered several dependent bugs for getting rid of lookup and xpath in related libs, against bug 503192. They are

bug 879884 lib/downloads.js
bug 879938 lib/prefs.js
bug 879946 lib/search.js
bug 879948 lib/software-update.js
bug 879950 lib/tabs.js
bug 879953 lib/toolbars.js

Comment 9

[Sylvestre Ledru [:Sylvestre]]

Mozmill is dead, WONTFIX the remaining bugs.