874601 - (Australis) 2 Failing social API tests on OS X on UX

Status: RESOLVED FIXED

(Firefox :: Toolbars and Customization, defect)

Description

[:Gijs (he/him)]

Both opt and debug, all versions. On debug, it looks like:

09:20:06 WARNING - TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/base/content/test/social/browser_social_toolbar.js | sub-test testNoAmbientNotificationsIsNoKeyboardMenu failed: TypeError: document.getElementById(...).openPopup is not a function
09:20:06 WARNING - TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/base/content/test/social/browser_social_toolbar.js | status value is correct - Got , expected 42
09:20:06 WARNING - TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/base/content/test/social/browser_social_toolbar.js | - Got , expected Test Ambient 1 ⁆ (42)
09:20:07 WARNING - TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/base/content/test/social/browser_social_toolbar.js | uncaught exception - TypeError: Social.provider is null at chrome://mochitests/content/browser/browser/base/content/test/social/browser_social_toolbar.js:131

Comment 1

[:Gijs (he/him)]

This is probably a timing issue with the next() calls and test finishing not happening before the rest of the code runs. Instead, there should just be returns after the next() calls. I've fired off a try run with this change:

https://tbpl.mozilla.org/?tree=Try&rev=112d80638293

Comment 2

[:Gijs (he/him)]

Attachment: Patch v1

Waiting with r? until try results come in.

Comment 3

[:Gijs (he/him)]

Comment on attachment 752603 [details] [diff] [review]
Patch v1

Try run was green, Mark, could you review this? :-)

Comment 4

[Mark Hammond [:markh] [:mhammond]]

Comment on attachment 752603 [details] [diff] [review]
Patch v1

Review of attachment 752603 [details] [diff] [review]:
-----------------------------------------------------------------

hrmph - I wonder why that isn't failing on m-c!

Comment 5

[:Gijs (he/him)]

Pushed to inbound: https://hg.mozilla.org/integration/mozilla-inbound/rev/8eebe35aae63

Comment 6

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/8eebe35aae63