Closed Bug 874601 Opened 11 years ago Closed 11 years ago

(Australis) 2 Failing social API tests on OS X on UX

Categories

(Firefox :: Toolbars and Customization, defect)

x86
macOS
defect
Not set
normal

Tracking

()

RESOLVED FIXED
Firefox 24

People

(Reporter: Gijs, Assigned: Gijs)

References

Details

Attachments

(1 file)

Both opt and debug, all versions. On debug, it looks like:

09:20:06 WARNING - TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/base/content/test/social/browser_social_toolbar.js | sub-test testNoAmbientNotificationsIsNoKeyboardMenu failed: TypeError: document.getElementById(...).openPopup is not a function
09:20:06 WARNING - TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/base/content/test/social/browser_social_toolbar.js | status value is correct - Got , expected 42
09:20:06 WARNING - TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/base/content/test/social/browser_social_toolbar.js | - Got , expected Test Ambient 1 ⁆ (42)
09:20:07 WARNING - TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/base/content/test/social/browser_social_toolbar.js | uncaught exception - TypeError: Social.provider is null at chrome://mochitests/content/browser/browser/base/content/test/social/browser_social_toolbar.js:131
This is probably a timing issue with the next() calls and test finishing not happening before the rest of the code runs. Instead, there should just be returns after the next() calls. I've fired off a try run with this change:

https://tbpl.mozilla.org/?tree=Try&rev=112d80638293
Assignee: nobody → gijskruitbosch+bugs
Status: NEW → ASSIGNED
Attached patch Patch v1Splinter Review
Waiting with r? until try results come in.
Comment on attachment 752603 [details] [diff] [review]
Patch v1

Try run was green, Mark, could you review this? :-)
Attachment #752603 - Flags: review?(mhammond)
Comment on attachment 752603 [details] [diff] [review]
Patch v1

Review of attachment 752603 [details] [diff] [review]:
-----------------------------------------------------------------

hrmph - I wonder why that isn't failing on m-c!
Attachment #752603 - Flags: review?(mhammond) → review+
https://hg.mozilla.org/mozilla-central/rev/8eebe35aae63
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 24
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: