Closed
Bug 874689
Opened 11 years ago
Closed 11 years ago
Make FilePicker use Async prompt service
Categories
(Firefox for Android Graveyard :: General, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
Firefox 24
People
(Reporter: wesj, Assigned: wesj)
References
Details
Attachments
(2 files)
21.61 KB,
patch
|
mfinkle
:
review+
|
Details | Diff | Splinter Review |
17.84 KB,
patch
|
blassey
:
review+
|
Details | Diff | Splinter Review |
No description provided.
Assignee | ||
Comment 1•11 years ago
|
||
Not sure if you'll love or hate this, but I moved the file picker to js to make it a bit easier to do this through message passing. I think I copied this fairly faithfully.
Attachment #752436 -
Flags: review?(blassey.bugs)
Assignee | ||
Comment 2•11 years ago
|
||
This hooks up the message listeners in Java. I didn't realize that the filePicker actually had an async api before this, but this moves all the dependency on whether we're async or not into js (by spinning an event loop in FilePicker.js), and out of the Native implementation parts. I've left a few bits around. The file picker is invoked via. the bridge (and not xpcom for some reason?) here: http://mxr.mozilla.org/mozilla-central/source/content/media/webrtc/MediaEngineDefault.cpp#188 so we can't quite kill it all yet.
Attachment #752440 -
Flags: review?(blassey.bugs)
Comment 3•11 years ago
|
||
Comment on attachment 752436 [details] [diff] [review] Patch 1/2 Review of attachment 752436 [details] [diff] [review]: ----------------------------------------------------------------- Finkle would be a better reviewer for this patch than me
Attachment #752436 -
Flags: review?(blassey.bugs) → review?(mark.finkle)
Comment 4•11 years ago
|
||
Comment on attachment 752440 [details] [diff] [review] Patch 2/2 Review of attachment 752440 [details] [diff] [review]: ----------------------------------------------------------------- ::: mobile/android/base/ActivityHandlerHelper.java @@ +184,5 @@ > > + private interface IntentHandler { > + public void gotIntent(Intent intent); > + } > + ws @@ +206,5 @@ > + public void onPromptFinished(String promptServiceResult) { > + int itemId = -1; > + try { > + itemId = new JSONObject(promptServiceResult).getInt("button"); > + ws
Attachment #752440 -
Flags: review?(blassey.bugs) → review+
Updated•11 years ago
|
Attachment #752436 -
Flags: review?(mark.finkle) → review+
Assignee | ||
Comment 5•11 years ago
|
||
try: https://tbpl.mozilla.org/?tree=Try&rev=7a59418f2dac
Assignee | ||
Comment 6•11 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/a38ef60582d9 https://hg.mozilla.org/integration/mozilla-inbound/rev/b6147b141643
Comment 7•11 years ago
|
||
Follow up to fix bustage on a CLOSED TREE: https://hg.mozilla.org/integration/mozilla-inbound/rev/3c08a0d87dc5
Comment 8•11 years ago
|
||
Backed out for Android build bustage. https://hg.mozilla.org/integration/mozilla-inbound/rev/acc549b97117
Assignee | ||
Comment 9•11 years ago
|
||
Grrr. Left my unbitrotting in the try commit. Folded everything into one: https://hg.mozilla.org/integration/mozilla-inbound/rev/1e8d7a30499d
Comment 10•11 years ago
|
||
nsFilePicker.cpp and nsFilePicker.h were accidentally un-deleted during some merging between branches. Re-deleted. https://hg.mozilla.org/integration/mozilla-inbound/rev/00119553c9d8
Comment 11•11 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/1e8d7a30499d https://hg.mozilla.org/mozilla-central/rev/00119553c9d8
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 24
Updated•11 years ago
|
Assignee: nobody → wjohnston
Updated•3 years ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•