Closed Bug 874729 Opened 7 years ago Closed 5 years ago
Add ability to run robocop tests to mach
It would be nice if we could run robocop tests from mach. ./mach help gives: > Testing: > Run tests. > > crashtest Run crashtests. > crashtest-ipc Run IPC crashtests. > gtest Run GTest unit tests. > jetpack-test Runs the jetpack test suite. > marionette-test Run a Marionette test. > mochitest-a11y Run an a11y mochitest. > mochitest-browser Run a mochitest with browser chrome. > mochitest-chrome Run a chrome mochitest. > mochitest-metro Run a mochitest with metro browser chrome. > mochitest-plain Run a plain mochitest. > reftest Run reftests. > reftest-ipc Run IPC reftests. > xpcshell-test Run XPCOM Shell tests. We should add another option, ./mach mochitest-robotium (or perhaps just 'robocop') that runs robocop tests on an android device.
6 years ago
Greg, I've flagged you for review since this is straight Python. Maybe redirect to gbrown? This depends on many of the pieces of Bug 929654.
Attachment #8481715 - Flags: review?(gps)
5 years ago
Depends on: 929654
Comment on attachment 8481715 [details] [diff] [review] Add |mach robocop|. r=gps Review of attachment 8481715 [details] [diff] [review]: ----------------------------------------------------------------- Please comply [with the review nits]. ::: testing/mochitest/mach_commands.py @@ +868,5 @@ > + if serve: > + args.append('--no-autorun') > + > + for test_name in test_names: > + args.append('--test-name=%s' % test_name) args.extend(['--test-name=%s' % t for t in test_names]) @@ +870,5 @@ > + > + for test_name in test_names: > + args.append('--test-name=%s' % test_name) > + > + sys.exit(runtestsremote.main(args)) return from mach commands.
Attachment #8481715 - Flags: review?(gps) → review+
I landed some of the pieces from Bug 929654 as parts of this ticket. I also made this |mach robocop-test| to keep in line with other suites. https://hg.mozilla.org/integration/fx-team/rev/cabc4055bf53 https://hg.mozilla.org/integration/fx-team/rev/5721e2cd0459 https://hg.mozilla.org/integration/fx-team/rev/9fe9d968b1d5 https://hg.mozilla.org/integration/fx-team/rev/1aa5d84e4689 https://hg.mozilla.org/integration/fx-team/rev/27d8e45f0e0d
Status: NEW → ASSIGNED
(In reply to Nick Alexander :nalexander from comment #3) > I landed some of the pieces from Bug 929654 as parts of this ticket. I also > made this |mach robocop-test| to keep in line with other suites. Oops, forgot to land the last bit. |mach robocop| it is, for now.
https://hg.mozilla.org/mozilla-central/rev/5721e2cd0459 https://hg.mozilla.org/mozilla-central/rev/9fe9d968b1d5 https://hg.mozilla.org/mozilla-central/rev/1aa5d84e4689 https://hg.mozilla.org/mozilla-central/rev/27d8e45f0e0d
Assignee: nobody → nalexander
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla35
You need to log in before you can comment on or make changes to this bug.