Closed Bug 874729 Opened 7 years ago Closed 5 years ago

Add ability to run robocop tests to mach

Categories

(Firefox Build System :: Mach Core, enhancement)

enhancement
Not set

Tracking

(Not tracked)

RESOLVED FIXED
mozilla35

People

(Reporter: jwir3, Assigned: nalexander)

References

(Depends on 1 open bug)

Details

Attachments

(1 file)

It would be nice if we could run robocop tests from mach. ./mach help gives:

> Testing:
>   Run tests.
> 
>   crashtest             Run crashtests.
>   crashtest-ipc         Run IPC crashtests.
>   gtest                 Run GTest unit tests.
>   jetpack-test          Runs the jetpack test suite.
>   marionette-test       Run a Marionette test.
>   mochitest-a11y        Run an a11y mochitest.
>   mochitest-browser     Run a mochitest with browser chrome.
>   mochitest-chrome      Run a chrome mochitest.
>   mochitest-metro       Run a mochitest with metro browser chrome.
>   mochitest-plain       Run a plain mochitest.
>   reftest               Run reftests.
>   reftest-ipc           Run IPC reftests.
>   xpcshell-test         Run XPCOM Shell tests.

We should add another option, ./mach mochitest-robotium (or perhaps just 'robocop') that runs robocop tests on an android device.
OS: Linux → All
Hardware: x86_64 → All
Component: Build Config → mach
Greg, I've flagged you for review since this is straight Python.
Maybe redirect to gbrown?

This depends on many of the pieces of Bug 929654.
Attachment #8481715 - Flags: review?(gps)
Comment on attachment 8481715 [details] [diff] [review]
Add |mach robocop|. r=gps

Review of attachment 8481715 [details] [diff] [review]:
-----------------------------------------------------------------

Please comply [with the review nits].

::: testing/mochitest/mach_commands.py
@@ +868,5 @@
> +        if serve:
> +            args.append('--no-autorun')
> +
> +        for test_name in test_names:
> +            args.append('--test-name=%s' % test_name)

args.extend(['--test-name=%s' % t for t in test_names])

@@ +870,5 @@
> +
> +        for test_name in test_names:
> +            args.append('--test-name=%s' % test_name)
> +
> +        sys.exit(runtestsremote.main(args))

return from mach commands.
Attachment #8481715 - Flags: review?(gps) → review+
(In reply to Nick Alexander :nalexander from comment #3)
> I landed some of the pieces from Bug 929654 as parts of this ticket.  I also
> made this |mach robocop-test| to keep in line with other suites.

Oops, forgot to land the last bit.  |mach robocop| it is, for now.
Flags: qe-verify-
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.