Closed Bug 874806 Opened 7 years ago Closed 4 years ago

GStreamerReader::PlayBinSourceSetupCb() doesn't need to do a bogus read anymore

Categories

(Core :: Audio/Video: Playback, defect, P5)

All
Linux
defect

Tracking

()

RESOLVED WONTFIX

People

(Reporter: cpearce, Assigned: alessandro.d)

References

Details

Attachments

(1 file)

GStreamerReader::PlayBinSourceSetupCb() does a read of 512 bytes [1] in order to block until ChannelMediaResource::Listener::OnStartRequest() has run so that MediaResource::GetLength() returns something other than -1.

But now that bug 872866 has landed, that shouldn't be necessary; MediaResource::GetLength() is now initialized much earlier from the original HTTPChannel's Content-Length header, if it has one. And if it doesn't have one then, it probably won't.

We should investigate if we can safely remove this read.

[1] http://mxr.mozilla.org/mozilla-central/source/content/media/gstreamer/GStreamerReader.cpp#202
Attached patch bug874806.patchSplinter Review
I did some local testing and the length is now correctly returned without the bogus read.

https://tbpl.mozilla.org/?tree=Try&rev=cb7365295b43
Attachment #8377324 - Flags: review?(cpearce)
Attachment #8377324 - Flags: review?(cpearce) → review+
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/183380b99514
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla30
Backed out for causing bug 974033.
https://hg.mozilla.org/integration/mozilla-inbound/rev/26487075b6ec
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Target Milestone: mozilla30 → ---
Component: Audio/Video → Audio/Video: Playback
gstreamer is going in bug 1234092
Status: REOPENED → RESOLVED
Closed: 6 years ago4 years ago
Resolution: --- → WONTFIX
You need to log in before you can comment on or make changes to this bug.