874806 - GStreamerReader::PlayBinSourceSetupCb() doesn't need to do a bogus read anymore

Status: RESOLVED WONTFIX

(Core :: Audio/Video: Playback, defect, P5)

Description

[Chris Pearce [:cpearce (Not reading bugmail)]]

GStreamerReader::PlayBinSourceSetupCb() does a read of 512 bytes [1] in order to block until ChannelMediaResource::Listener::OnStartRequest() has run so that MediaResource::GetLength() returns something other than -1.

But now that bug 872866 has landed, that shouldn't be necessary; MediaResource::GetLength() is now initialized much earlier from the original HTTPChannel's Content-Length header, if it has one. And if it doesn't have one then, it probably won't.

We should investigate if we can safely remove this read.

[1] http://mxr.mozilla.org/mozilla-central/source/content/media/gstreamer/GStreamerReader.cpp#202

Comment 1

[Alessandro Decina]

Attachment: bug874806.patch

I did some local testing and the length is now correctly returned without the bogus read.

https://tbpl.mozilla.org/?tree=Try&rev=cb7365295b43

Comment 2

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/183380b99514

Comment 3

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/183380b99514

Comment 4

[Ryan VanderMeulen [:RyanVM]]

Backed out for causing bug 974033.
https://hg.mozilla.org/integration/mozilla-inbound/rev/26487075b6ec

Comment 5

[Ryan VanderMeulen [:RyanVM]]

Merge of backout:
https://hg.mozilla.org/mozilla-central/rev/26487075b6ec

Comment 6

[Jean-Yves Avenard [:jya]]

gstreamer is going in bug 1234092