874892 - [system][modal dialogs] queuing alert events

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::System, defect, P1)

Description

[Etienne Segonzac (:etienne)]

Some background, if an app does

|alert("first");alert("second");|

we won't execute the |alert("second")| until the user taps the OK button on the first alert.

But, if and apps send an alert() in a system message handler (and receives multiple system messages in a row) we can end up with the queue of alerts to handle.

This is needed to handle the SMS of class 0 which are displayed with an alert().

+++ This bug was initially created as a clone of Bug #858908 +++

AU_LINUX_GECKO_ICS_STRAWBERRY_V1.01.00.01.19.053
 Firefox os  v1.0.1
 Mozilla build ID: 20130327153857
 
 +++ This bug was initially created as a clone of Bug #431424 +++
 
 [WuYing][6915]
 
 DEFECT DESCRIPTION:
 If received more than 2 SMS of Class 0 type, just can read one SMS detail infomation
 
 
 REPRODUCING PROCEDURES:
 1.after received more than 2 SMS of Class 0 type
 2.These SMSM  will prompt in notification.
 3.pull dowm the status bar
 4.Select one Class0 SMS to tap
 5.It will show detail information
 6.But other Class0 SMS will disappear,cannot read detail meessage---KO
 
 EXPECTED BEHAVIOUR:
 read all Class0 SMS detail infomation
 
 ASSOCIATE SPECIFICATION:
 
 TEST PLAN REFERENCE:
 
 TOOLS AND PLATFORMS USED:
 
 USER IMPACT:
 medium
 REPRODUCING RATE:
 5/5
 For FT PR, Please list reference mobile's behavior:
 
 ++++++++++ end of initial bug #431424 description ++++++++++
 
 
 
 CONTACT INFO (Name,Phone number):
 
  DEFECT DESCRIPTION:
 
  REPRODUCING PROCEDURES:
 
  EXPECTED BEHAVIOUR:
 
  ASSOCIATE SPECIFICATION:
 
  TEST PLAN REFERENCE:
 
  TOOLS AND PLATFORMS USED:
 
  USER IMPACT:
 
  REPRODUCING RATE:
 
  For FT PR, Please list reference mobile's behavior:

Comment 1

[Etienne Segonzac (:etienne)]

Attachment: Patch proposal

Comment 2

[(inactive after 6/18) Alive Kuo [:alive]]

Comment on attachment 752744 [details] [diff] [review]
Patch proposal

Review of attachment 752744 [details] [diff] [review]:
-----------------------------------------------------------------

Code looks fine. r=alive. You did something I want to do.

Comment 3

[(inactive after 6/18) Alive Kuo [:alive]]

(In reply to Alive Kuo [:alive] from comment #2)
> Code looks fine. r=alive. You did something I want to do.
(But no time ;)

Comment 4

[Etienne Segonzac (:etienne)]

https://github.com/mozilla-b2g/gaia/commit/85a9752e0012bef2796d7a8391d850afd3a557cc

Comment 5

[Gareth Aye [:gaye] (back from PTO)]

Uplifted 85a9752e0012bef2796d7a8391d850afd3a557cc to:
v1-train: 1c1bcfbac112a8a363341f3b1b6607cb40849515

Comment 6

[Jason Smith [:jsmith]]

Attachment: Test Case

Test case for verification attached

Comment 7

[Jason Smith [:jsmith]]

Attachment: Test Case

Comment 8

[Jason Smith [:jsmith]]

lgtm with attached test case on 5/28 build