874917 - Defect - Find bar disappears while touch scrolling page

Status: VERIFIED FIXED

(Firefox for Metro Graveyard :: Browser, defect, P3)

Description

[Rodrigo Silveira [:rsilveira] [:rodms]]

Very odd behavior. Strangelly enough, it doesn't happen when scrolling with mouse. It looks worse after the padding added by Bug 867641.

Comment 1

[Rodrigo Silveira [:rsilveira] [:rodms]]

Attachment: Patch v1

Removed code that was hiding the findbar when panning.

Comment 2

[Rodrigo Silveira [:rsilveira] [:rodms]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/beccca95bd49

Comment 3

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/beccca95bd49

Comment 4

[Marco Mucci [:MarcoM]]

For testing and verification.

Comment 5

[Virgil Dicu [:virgil] [QA]]

No touch device here, so leaving to Juan.

Comment 6

[Allison Naaktgeboren :ally]

I couldn't repro this in testing for iter8. rsilivera, did you have a particular test case for this one?

Comment 7

[Rodrigo Silveira [:rsilveira] [:rodms]]

Yes, you just need to touch scroll on any page while the findbar is showing. The find bar would disappear while scrolling before the fix.

Comment 8

[Kamil Jozwiak [:kjozwiak]]

Went through the following "Defect" for iteration #9 testing without any issues. Used the following build:

http://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/2013-07-06-03-12-13-mozilla-central/

- Reproduced the original issue using an older version of Metro Firefox. Scrolling using touch would hide the "Find" bar and then re-appear once scrolling stopped
- Ensured that the "Find" bar doesn't dismiss when scrolling through websites (using both touch/mouse)
- Ensured that inserting a word in the "Find" bar doesn't dismiss when scrolling through websites (using both touch/mouse)
- Ensured that swiping the "Navigation App Bar" from the top while the "Find" bar is visible, replaces the "Find" bar with the "URL" bar without any issues
- Ensured that pressing the "Back" overlay button while the "Find" bar is visible, dismisses the "Find" bar and goes back to the previous website without any issues
- Ensured that pressing the "New Tab" overlay button while the "Find" bar is visible dismisses the "Find" bar and creates a new tab without any issues

Comment 9

[juan becerra [:juanb]]

Retested for iteration #10 using the information in comment #8 and although the find bar no longer disappears when scrolling it did disappear when I entered a search term. Filed bug 898678 for it.

Comment 10

[Samvedana (:Samvedana)]

User Agent: Mozilla/5.0 (Windows NT 6.2; Win64; x64; rv:26.0) Gecko/20100101 Firefox/26.0
Build ID: 20130807030216
Built from http://hg.mozilla.org/mozilla-central/rev/1fb5d14e8348

WFM
Tested on windows 8 using latest nightly for iteration-11. Followed steps provided in comment7 and got expected result.

Comment 11

[Samvedana (:Samvedana)]

User Agent: Mozilla/5.0 (Windows NT 6.2; WOW64; rv:26.0) Gecko/20100101 Firefox/26.0
Build ID: 20130816030205
Built from http://hg.mozilla.org/mozilla-central/rev/1ed5a88cd4d0

WFM
Tested on windows 8 using latest nightly for iteration-12. Followed steps provided in comment7 and got expected result.

Comment 12

[Kamil Jozwiak [:kjozwiak]]

Went through the following "Defect" for iteration #15 without any issues. Used the following build:
http://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/2013-10-02-03-02-01-mozilla-central/

- Went through the original test case(s) described in comment #0 without any issues
- Went through the test cases added in comment #8 without any issues
- Ensured that all of the above test cases worked with full & filled views without any issues

Comment 13

[Kamil Jozwiak [:kjozwiak]]

Went through the following defect for iteration #20 without any issues. Used the following build:
http://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/2013-12-22-03-02-04-mozilla-central/

- Went through the original test case in comment #0 without any issues
- Went through the test cases added in comment #8 without any issues
- Scrolled through several websites with the Find App Bar visible and everything worked as expected
- Went through many of the same test cases from the following bugs: Bug 831940, Bug 852805, Bug 863060, Bug 857437 and Bug 879115