874929 - Adjust feed subscribe dialog css for recent folderpicker menulist changes

Status: RESOLVED FIXED

(Thunderbird :: Theme, defect)

Description

[alta88]

moving between a folder and feed in the tree causes the info section to jump due to height differences in menulist and textbox.

Comment 1

[alta88]

Attachment: patch

Comment 2

[Richard Marti (:Paenglab)]

Comment on attachment 752799 [details] [diff] [review]
patch

Good catch

On Windows and Linux it's looking good and fixes the jumping. On OS X it is still jumping because 2.3em is less tall than the menulist is. Either changing the height to 2.5em or removing the line '#rssFeedInfoBox row,' would solve this. But let still removed the #selectFolder rule (this one is causing the jumping on OS X).

The code is looking good, so r+. ui-r- for the OS X jumping.

Comment 3

[alta88]

Attachment: updated

updated.  i wonder if the #statusContainerBox height rule is even needed on osx?

Comment 4

[Richard Marti (:Paenglab)]

Comment on attachment 752892 [details] [diff] [review]
updated

No jumping now also on OS X.

(In reply to alta88 from comment #3)
> Created attachment 752892 [details] [diff] [review]
> updated.  i wonder if the #statusContainerBox height rule is even needed on
> osx?

It's needed. Without this rule the box is only 4px tall and grows when a status text/progress meter is shown.

Comment 5

[alta88]

ok, thanks.  especially for the fast turnaround.

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/comm-central/rev/5a2edf97c442

Comment 7

[Kelsey Gilbert [:jgilbert]]

Backed out:
https://tbpl.mozilla.org/?tree=Mozilla-Inbound&rev=2defb982c769


Looks like a warnings-as-errors failure.

Comment 8

[Kelsey Gilbert [:jgilbert]]

(In reply to Jeff Gilbert [:jgilbert] from comment #7)
> Backed out:
> https://tbpl.mozilla.org/?tree=Mozilla-Inbound&rev=2defb982c769
> 
> 
> Looks like a warnings-as-errors failure.

Ack, wrong bug. :\