Last Comment Bug 874929 - Adjust feed subscribe dialog css for recent folderpicker menulist changes
: Adjust feed subscribe dialog css for recent folderpicker menulist changes
Status: RESOLVED FIXED
:
Product: Thunderbird
Classification: Client Software
Component: Theme (show other bugs)
: unspecified
: All All
: -- normal (vote)
: Thunderbird 24.0
Assigned To: alta88
:
:
Mentors:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2013-05-22 09:23 PDT by alta88
Modified: 2013-05-28 16:43 PDT (History)
2 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---


Attachments
patch (1.77 KB, patch)
2013-05-22 09:25 PDT, alta88
richard.marti: review+
richard.marti: ui‑review-
Details | Diff | Splinter Review
updated (1.75 KB, patch)
2013-05-22 12:30 PDT, alta88
alta88: review+
richard.marti: ui‑review+
Details | Diff | Splinter Review

Description alta88 2013-05-22 09:23:12 PDT
moving between a folder and feed in the tree causes the info section to jump due to height differences in menulist and textbox.
Comment 1 alta88 2013-05-22 09:25:51 PDT
Created attachment 752799 [details] [diff] [review]
patch
Comment 2 Richard Marti (:Paenglab) 2013-05-22 11:25:39 PDT
Comment on attachment 752799 [details] [diff] [review]
patch

Good catch

On Windows and Linux it's looking good and fixes the jumping. On OS X it is still jumping because 2.3em is less tall than the menulist is. Either changing the height to 2.5em or removing the line '#rssFeedInfoBox row,' would solve this. But let still removed the #selectFolder rule (this one is causing the jumping on OS X).

The code is looking good, so r+. ui-r- for the OS X jumping.
Comment 3 alta88 2013-05-22 12:30:30 PDT
Created attachment 752892 [details] [diff] [review]
updated


updated.  i wonder if the #statusContainerBox height rule is even needed on osx?
Comment 4 Richard Marti (:Paenglab) 2013-05-22 12:49:07 PDT
Comment on attachment 752892 [details] [diff] [review]
updated

No jumping now also on OS X.

(In reply to alta88 from comment #3)
> Created attachment 752892 [details] [diff] [review]
> updated.  i wonder if the #statusContainerBox height rule is even needed on
> osx?

It's needed. Without this rule the box is only 4px tall and grows when a status text/progress meter is shown.
Comment 5 alta88 2013-05-22 13:31:00 PDT
ok, thanks.  especially for the fast turnaround.
Comment 6 Ryan VanderMeulen [:RyanVM] 2013-05-28 10:17:02 PDT
https://hg.mozilla.org/comm-central/rev/5a2edf97c442
Comment 7 Jeff Gilbert [:jgilbert] 2013-05-28 16:43:24 PDT
Backed out:
https://tbpl.mozilla.org/?tree=Mozilla-Inbound&rev=2defb982c769


Looks like a warnings-as-errors failure.
Comment 8 Jeff Gilbert [:jgilbert] 2013-05-28 16:43:42 PDT
(In reply to Jeff Gilbert [:jgilbert] from comment #7)
> Backed out:
> https://tbpl.mozilla.org/?tree=Mozilla-Inbound&rev=2defb982c769
> 
> 
> Looks like a warnings-as-errors failure.

Ack, wrong bug. :\

Note You need to log in before you can comment on or make changes to this bug.