Closed Bug 874929 Opened 6 years ago Closed 6 years ago

Adjust feed subscribe dialog css for recent folderpicker menulist changes


(Thunderbird :: Theme, defect)

Not set


(Not tracked)

Thunderbird 24.0


(Reporter: alta88, Assigned: alta88)



(1 file, 1 obsolete file)

1.75 KB, patch
: review+
: ui-review+
Details | Diff | Splinter Review
moving between a folder and feed in the tree causes the info section to jump due to height differences in menulist and textbox.
Attached patch patch (obsolete) — Splinter Review
Assignee: nobody → alta88
Attachment #752799 - Flags: review?(richard.marti)
Comment on attachment 752799 [details] [diff] [review]

Good catch

On Windows and Linux it's looking good and fixes the jumping. On OS X it is still jumping because 2.3em is less tall than the menulist is. Either changing the height to 2.5em or removing the line '#rssFeedInfoBox row,' would solve this. But let still removed the #selectFolder rule (this one is causing the jumping on OS X).

The code is looking good, so r+. ui-r- for the OS X jumping.
Attachment #752799 - Flags: ui-review-
Attachment #752799 - Flags: review?(richard.marti)
Attachment #752799 - Flags: review+
Attached patch updatedSplinter Review
updated.  i wonder if the #statusContainerBox height rule is even needed on osx?
Attachment #752799 - Attachment is obsolete: true
Attachment #752892 - Flags: ui-review?(richard.marti)
Attachment #752892 - Flags: review+
Comment on attachment 752892 [details] [diff] [review]

No jumping now also on OS X.

(In reply to alta88 from comment #3)
> Created attachment 752892 [details] [diff] [review]
> updated.  i wonder if the #statusContainerBox height rule is even needed on
> osx?

It's needed. Without this rule the box is only 4px tall and grows when a status text/progress meter is shown.
Attachment #752892 - Flags: ui-review?(richard.marti) → ui-review+
ok, thanks.  especially for the fast turnaround.
Keywords: checkin-needed
Closed: 6 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 24.0
Backed out:

Looks like a warnings-as-errors failure.
(In reply to Jeff Gilbert [:jgilbert] from comment #7)
> Backed out:
> Looks like a warnings-as-errors failure.

Ack, wrong bug. :\
You need to log in before you can comment on or make changes to this bug.