874989 - clean up dashboard intergration

Status: RESOLVED FIXED

(Webmaker Graveyard :: Login, defect)

Description

[Pomax]

the code we added on monday to get the /myprojects link to work in Thimble is very hacky and needs to be taken out ASAP.

I'd recommend we turn this into a node module (similar to webmaker-loginapi) that gives any app a /myprojects route, which -when accessed- contacts webmaker.org for the dashboard page content. That way requests are always local as far as the browser is concerned, and we can do DOM manipulation (ajax-inject the resulting page, etc) as much as we like.

Comment 1

[Mike Beltzner [:beltzner, not reading bugmail]]

So would that mean that this ought to live in webmaker.org and be a generalized bit of code?

Comment 2

[Pomax]

I was thinking we make it part of the userbar, since that sets up the HTML where this will live. Since it's universal functionality, the part that shows 'my makes' would be in login.webmaker.org, and the page that we pull up comes from webmaker.org/myprojects

Comment 3

[Pomax]

finished this up specifically for thimble, this is ready for moving into login/webmaker

Comment 4

[Pomax]

Attachment: https://github.com/mozilla/login.webmaker.org/pull/69

Comment 5

[Ross Bruniges [:boozeniges]]

Comment on attachment 753368 [details] [review]
https://github.com/mozilla/login.webmaker.org/pull/69

Nice and simple, I like simple

Comment 6

[Pomax]

forgot to update the README, so I'll add that and do a quick re-r+ request.

Comment 7

[Pomax]

Comment on attachment 753368 [details] [review]
https://github.com/mozilla/login.webmaker.org/pull/69

forgot the README.

Comment 8

[Ross Bruniges [:boozeniges]]

Comment on attachment 753368 [details] [review]
https://github.com/mozilla/login.webmaker.org/pull/69

Sort out the gruntfile (comment in github) and this is good to go

Comment 9

[Pomax]

landed.