If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

update thimble to new 'my makes' option in the site-wide user bar

RESOLVED FIXED

Status

Webmaker
Thimble
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: pomax, Assigned: pomax)

Tracking

Details

Attachments

(1 attachment)

Comment hidden (empty)
(Assignee)

Updated

4 years ago
Summary: update thimble to 'my makes → update thimble to new 'my makes' option in the site-wide user bar
(Assignee)

Comment 1

4 years ago
Created attachment 753391 [details] [review]
https://github.com/mozilla/thimble.webmaker.org/pull/77
Attachment #753391 - Flags: review?(scott)
(Assignee)

Updated

4 years ago
Depends on: 874989
Comment on attachment 753391 [details] [review]
https://github.com/mozilla/thimble.webmaker.org/pull/77

Shouldn't the public/js/userbar.js file be nukable now?

Looks nice and simple otherwise.

I don't see any other files that reference my projects.
Attachment #753391 - Flags: review?(scott) → review-
(Assignee)

Comment 3

4 years ago
actually, userbar.js *and* nav.css, and I'm pretty sure I killed them off. wonder why they're not showing, let me update the pull O_o
(Assignee)

Comment 4

4 years ago
Comment on attachment 753391 [details] [review]
https://github.com/mozilla/thimble.webmaker.org/pull/77

updated!
Attachment #753391 - Flags: review- → review?(scott)
Attachment #753391 - Flags: review?(scott) → review+
(Assignee)

Comment 5

4 years ago
landed.
Status: ASSIGNED → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
Attachment mime type: text/plain → text/x-github-pull-request
You need to log in before you can comment on or make changes to this bug.