[Building blocks][Switches] Background goes beyond component's boundaries

RESOLVED FIXED

Status

RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: sergiov, Assigned: arnau)

Tracking

unspecified
x86
Mac OS X
Dependency tree / graph

Firefox Tracking Flags

(b2g18 fixed, b2g-v1.1hd fixed)

Details

Attachments

(2 attachments)

(Reporter)

Description

5 years ago
Created attachment 753176 [details]
Screenshot displaying the error

When you tap the component to change its state, the background is painted beyond component's boundaries. It seems the problem only happens during the transition from one state to the other.
Created attachment 753188 [details]
Patch
Attachment #753188 - Flags: review?(igonzaleznicolas)
Comment on attachment 753188 [details]
Patch

After turning a little bit crazy Arnau, we got a stable way to make this new switches work in a simplified way, bugs bulletproof and susceptible to crossbrowsing.
Grat work Arnau, thx!
Attachment #753188 - Flags: review?(igonzaleznicolas) → review+
Component: General → Gaia
Comment on attachment 753188 [details]
Patch

NOTE: Please see https://wiki.mozilla.org/Release_Management/B2G_Landing to better understand the B2G approval process and landings.

[Approval Request Comment]
Bug caused by (feature/regressing bug #): 
User impact if declined: Weird effect in switches with current inplementation
Testing completed: Yes
Risk to taking this patch (and alternatives if risky): very low, simplified CSS
String or UUID changes made by this patch:
Attachment #753188 - Flags: approval-gaia-v1?
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Commit: 78df925a6326ef0fbc5b86285303ae03f095d535

Comment 5

5 years ago
Comment on attachment 753188 [details]
Patch

Could cause polish regressions that we'd rather avoid - will ship in 1.2 first.
Attachment #753188 - Flags: approval-gaia-v1? → approval-gaia-v1-
It's a very low-risk patch and visually is an important improvement (adding ni on Jaime so she can comment). 

I would like triagers to reconsider this as we are in parallel still landing bigger patches related with new functionalities as MMS and current 1.1 experience is worse than 1.0.1.
Flags: needinfo?(jachen)
Flags: needinfo?(swilkes)
Clearing the needinfo flag, after talking with Stephany and Jaime they have confirmed me that they agree with trying to land this patch in v1-train and fixing this bug.
Flags: needinfo?(swilkes)
Flags: needinfo?(jachen)
Attachment #753188 - Flags: approval-gaia-v1- → approval-gaia-v1?
After talking to Maria and the rest of the team we want to ask for gaia approval again. This patch has 0 risk and fixes an ugly effect in switches, which has priority for the UX team.

Comment 9

5 years ago
Comment on attachment 753188 [details]
Patch

Upon further consideration given the even lower risk evaluation, we'll approve.
Attachment #753188 - Flags: approval-gaia-v1? → approval-gaia-v1+
status-b2g18: --- → affected
It seems like the patch regressed bug 880567. 

label input[type="checkbox"][data-type="switch"].uninit + span {
  transition: none;
  opacity: 0.4;
}

The span should not have an opacity 0.4.
I was not able to uplift this bug to v1-train.  If this bug has dependencies which are not marked in this bug, please comment on this bug.  If this bug depends on patches that aren't approved for v1-train, we need to re-evaluate the approval.  Otherwise, if this is just a merge conflict, you might be able to resolve it with:

  git checkout v1-train
  git cherry-pick -x -m1 78df925a6326ef0fbc5b86285303ae03f095d535
  <RESOLVE MERGE CONFLICTS>
  git commit
Flags: needinfo?(arnau)
Depends on: 880567
Flags: needinfo?(arnau)
Blocks: 880567
No longer depends on: 880567
v1-train -> a713a6f27c2cb627f7824e760635179f7ec8c9e0
status-b2g18: affected → fixed
1.1hd: a713a6f27c2cb627f7824e760635179f7ec8c9e0
status-b2g-v1.1hd: --- → fixed
You need to log in before you can comment on or make changes to this bug.