880567 - [Settings] Airplane mode and geolocation toggles are translucent always

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Settings, defect)

Description

[Arthur Chen [:arthurcc][inactive after 6/30]]

Attachment: screenshot

STR:
1. Launch settings app.
2. Check toggles for airplane mode and geolocation.

Current behavior:
The toggles are translucent always

Expected behavior:
The toggles are solid.

Comment 1

[Arthur Chen [:arthurcc][inactive after 6/30]]

Regressed by bug 875239.

Comment 2

[Arnau March [:arnau] ( not working in Firefox OS anymore :( )]

Attachment: Patch

Comment 3

[Ismael Gonzalez [:basiclines]]

Comment on attachment 760314 [details]
Patch

Cosmetic changes, r+

Comment 4

[Arnau March [:arnau] ( not working in Firefox OS anymore :( )]

Comment on attachment 760314 [details]
Patch

NOTE: Please see https://wiki.mozilla.org/Release_Management/B2G_Landing to better understand the B2G approval process and landings.

[Approval Request Comment]
Bug caused by (feature/regressing bug #): 
User impact if declined: 2 Switches in settings has some transparency that should not have, and they look disabled. The wanted effect for this 2 switches was to avoid initial animation when first entering in settings app, but instead an opacity was applied. This should land in V1-train together with bug: 875239 which already has the gaia-v1 approval
Testing completed: yes
Risk to taking this patch (and alternatives if risky): very low, it's only the opacity value in CSS.
String or UUID changes made by this patch:

Comment 5

[Alex Keybl [:akeybl]]

Comment on attachment 760314 [details]
Patch

We're past the point of approval-gaia-v1 noms in 1.1's schedule. If you feel this is a critical blocker, please set blocking-b2g:leo+

Comment 6

[Alex Keybl [:akeybl]]

blocking-b2g:leo?*

Comment 7

[bhavana bajaj [:bajaj]]

Blocking on this only because its a regression and the risk is very low.

Comment 8

[Ryan VanderMeulen [:RyanVM]]

--> jhford for landing on master (I think?) and v1-train.

Comment 9

[John Ford [:jhford] CET/CEST Berlin Time]

Nope, only uplifting.  There are two new selectors added to the css rule that's being changed which is causing a merge conflict.  I assume that it's a simple resolution, but I'd rather have someone who knows the code take care of it.

Comment 10

[Arnau March [:arnau] ( not working in Firefox OS anymore :( )]

It's a very simple patch, in:
label input[type="checkbox"][data-type="switch"].uninit + span {
   transition: none;
   opacity: 0.4;
}
You only have to remove:
opacity: 0.4;

As you can see here: https://github.com/mozilla-b2g/gaia/pull/10289/files
Thanks.

Comment 11

[Evelyn Hung]

(In reply to arnau from comment #10)
> It's a very simple patch, in:
> label input[type="checkbox"][data-type="switch"].uninit + span {
>    transition: none;
>    opacity: 0.4;
> }
> You only have to remove:
> opacity: 0.4;
> 
> As you can see here: https://github.com/mozilla-b2g/gaia/pull/10289/files
> Thanks.

You may need one of Settings app's maintainer to review and merge/uplift the code.

Comment 12

[Evelyn Hung]

Comment on attachment 760314 [details]
Patch

Arthur, can you take a look of this patch and help on merge to master if r+? Thanks.

Comment 13

[Arthur Chen [:arthurcc][inactive after 6/30]]

Comment on attachment 760314 [details]
Patch

The patch was already merged when Ismael gave an r+.

master: https://github.com/mozilla-b2g/gaia/commit/49d7cee07f3d8d18e28ef931271d5d23278216d5

I'll help uplift it to v1-train.

Comment 14

[Arthur Chen [:arthurcc][inactive after 6/30]]

The bug depends on bug 875239 that is not resolved in v1-train yet.

Comment 15

[Arnau March [:arnau] ( not working in Firefox OS anymore :( )]

Arthur, I have solved 875239 in v1-train. I had this bug as blocker not to uplift 875239 until we had gaia approval for this one as well. Thanks!

Comment 16

[Arthur Chen [:arthurcc][inactive after 6/30]]

I thought we can land this patch in v1-train because this bug is leo+. Is that correct?

Comment 17

[Arnau March [:arnau] ( not working in Firefox OS anymore :( )]

Yes, is leo +, I just wanted to uplift both bugs at the same time.
Now 875239 is in v1-train and now 880567 has to be uplifted as well.
Thanks!

Comment 18

[Deepa Subramanian]

When the user goes to Settings and scroll up and down, the user is able to view the toggle button colors are lighter for "Airplane" and "GPS" than that of "USB storage" button.

This issue is still found on leo device.
Leo Build ID: 
Build ID: 20130625070217
Gecko: http://hg.mozilla.org/releases/mozilla-b2g18/rev/29933d1937db
Gaia: 1436e2778b90bd74635b0b94d1cf8ccb0d71b60c
Platform Version: 18.1
RIL Version: 01.01.00.019.138

Comment 19

[Fabien Cazenave [:kaze]]

Bug 875239 has been uplifted. Marking this one as resolved/fixed so that it can be uplifted, too.

Comment 20

[Gareth Aye [:gaye] (back from PTO)]

Uplifted 49d7cee07f3d8d18e28ef931271d5d23278216d5 to:
v1-train: 0daca2d6df6abece2c6dbbcd4aeeda0579f2463d

Comment 21

[John Hammink]

Gecko  http://hg.mozilla.org/releases/mozilla-b2g18/rev/282b5c37cf8d
Gaia   e2ef782119b7e79fc62c48d36f0c36909d982988
BuildID 20130712070210
Version 18.0

Not seeing the issue on today's nightly.  Closing.

Comment 22

[Cody Roesch [:croesch]]

Verified as fixed on Leo with variables below. These toggles appear the same as other toggles when toggled off. They no longer seem to be confused with being disabled.

Environmental Variables
Build ID: 20130717070237
Gecko: http://hg.mozilla.org/releases/mozilla-b2g18/rev/582e3a7018b0
Gaia: c506c50adaaebcf729ac3c27887ba2931ab79040
Platform Version: 18.1
RIL Version: 01.01.00.019.158

Comment 23

[John Ford [:jhford] CET/CEST Berlin Time]

v1.1.0hd: 0daca2d6df6abece2c6dbbcd4aeeda0579f2463d