875314 - [SMS] Multi-recipient SMS should return to thread list after clicking "send"

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::SMS, defect)

Description

[Borja Salguero [:borjasalguero]]

When sending a SMS to 'a' & 'b' message 'Hola'

EXPECTED:
We will go to 'thread-list' showing thread 'a' & 'b'

CURRENTLY:
We are stucked in thread 'a'

Comment 1

[Maria Angeles Oteo (:oteo)]

Besides, as you are stucked in the thread 'a', you will see REPEATED the SMS that you have sent.
In case you have more recipients (n), the message will be shown n times repeated, which is not very nice :(

Once you go back to the threads list, the messages are properly refreshed, so if you enter in the 'a' thread only one message appears, as it's expected.

Comment 2

[Rick Waldron [:rwaldron]]

Attachment: Fix for 875314

Comment 3

[Corey Frang [:gnarf]]

Comment on attachment 753446 [details] [review]
Fix for 875314

r=me - everything looks good, and yay for more lines of tests than lines of code :)

Comment 4

[Corey Frang [:gnarf]]

master: 2da46510f3256e99252454a9fc37630bad8ed712

Comment 5

[John Ford [:jhford] CET/CEST Berlin Time]

v1-train: d4cd064

Comment 6

[John Hammink]

Punting this back to you.  The testcase above is not clear, and needs a rewrite.

Comment 7

[John Hammink]

I just checked this case against the latest 1.4 (see build details below) and found that we are still behaving the way the original STR specifies: that is, when I send an SMS to "a" and "b", I am still in thread "a"  (thread "b" is in a separate thread).

Therefore if the STR Expected outcome is the correct one then this bug isn't fixed.  Therefore I'll file a new bug against this.

Comment 8

[Noemí Freire (:noemi)]

(In reply to John Hammink from comment #7)
> I just checked this case against the latest 1.4 (see build details below)
> and found that we are still behaving the way the original STR specifies:
> that is, when I send an SMS to "a" and "b", I am still in thread "a" 
> (thread "b" is in a separate thread).
> 
> Therefore if the STR Expected outcome is the correct one then this bug isn't
> fixed.  Therefore I'll file a new bug against this.

Hi,

Group messaging functionality has not been implemented yet so the behavior you mention in master related to sending a SMS to multiple recipients (separate threads are created) is the current expected one. 
Notice that in case of sending a MMS to multiple recipients a specific thread is created with all the recipients but the responses coming from each participant will open a new specific thread.

Comment 9

[Julien Wajsberg [:julienw]]

But we are actually supposed to go to the thread list. I saw exactly what you're saying John, can you file a bug about this ? This is a regression for sure.

Comment 10

[Noemí Freire (:noemi)]

(In reply to Julien Wajsberg [:julienw] from comment #9)
> But we are actually supposed to go to the thread list. I saw exactly what
> you're saying John, can you file a bug about this ? This is a regression for
> sure.

Ok, I now see your point (it should return to the thread messages list not remaining in a specific thread), in this case it is also occurring on today's (3/3) v1.3 build:
Device: Hamachi
BuildId: 20140303132250
Platform version: 28.0
Gecko: a7d7506
Gaia: d51d2e0

Comment 11

[Julien Wajsberg [:julienw]]

Just saw that John filed Bug 978321 :)
Thanks John !