875472 - Version 22b1 - Close/Minimize functions top right are disabled/masked when non-standard themes are used

Status: RESOLVED FIXED

Description

[plongar]

Created attachment 753451 [details]
menubar.png

User Agent: Mozilla/5.0 (Windows NT 6.2; WOW64; rv:22.0) Gecko/20100101 Firefox/22.0 (Beta/Release)
Build ID: 20130521223249

Steps to reproduce:

Upgraded Thunderbird from version 21b1 to 22b1.
Opened application with an installed non-standard theme.

  


Actual results:

Three top right functions to minimalize or minimize or close Thunderbird on menu bar were not showing and clickable. 
Installed another non standard theme (Thunderbird Suave) to assess if previous theme might be the cause but with same result. 
The standard theme is working properly.


Expected results:

Functions should have been visible and accessible.
See also attached image showing a black bar masking the functions.

My system is running Windows 8.

Comment 1

[Richard Marti (:Paenglab)]

Created attachment 753852 [details] [diff] [review]
patch

I thought -moz-appearance: -moz-win-borderless-glass isn't needed on Win8 as the captions where still painted without this rule, so I moved it to @media (-moz-windows-glass) for Vista/Win7 only. But now I see it's still needed when personas are used. :(

Comment 2

[Richard Marti (:Paenglab)]

Created attachment 753946 [details] [diff] [review]
patch

The icons on tabbar-toolbar with dark personas need also to be inverted on Win8.

Comment 3

[Richard Marti (:Paenglab)]

Created attachment 754094 [details] [diff] [review]
patch

This should be now the final patch. The icons in the tab-bar on Win8 are now again white like IE is using it.

Comment 4

[Mike Conley (:mconley) - Buried in needinfo / review backlog, eating my way out]

Richard - I'm not in a place where I can run a build with this patch on Windows 8. Would it be possible for you to post some screenshots with your patch applied?

Comment 5

[Richard Marti (:Paenglab)]

Created attachment 757141 [details]
patch in action

Comment 6

[Mike Conley (:mconley) - Buried in needinfo / review backlog, eating my way out]

Comment on attachment 754094 [details] [diff] [review]
patch

Review of attachment 754094 [details] [diff] [review]:
-----------------------------------------------------------------

I'm not able to test this, but the CSS looks sane and the screenshot looks good. Thanks Richard!

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/comm-central/rev/5ccef067e4d7

Comment 8

[Richard Marti (:Paenglab)]

Comment on attachment 754094 [details] [diff] [review]
patch

[Approval Request Comment]
Regression caused by (bug #): 832666
User impact if declined: window not resizeable/closeable with window captions. New bugs in beta channel.
Risk to taking this patch (and alternatives if risky): It's only css and by this this should be low risk.

Comment 9

[Mark Banner (:standard8) (afk 21 - 30 July)]

https://hg.mozilla.org/releases/comm-aurora/rev/468eda0bcf7e