Closed
Bug 875545
Opened 12 years ago
Closed 12 years ago
Make Telephony.h/cpp to use EventListenerAdded/Removed
Categories
(Core :: DOM: Device Interfaces, defect)
Tracking
()
RESOLVED
FIXED
mozilla24
People
(Reporter: smaug, Assigned: smaug)
References
Details
Attachments
(2 files, 1 obsolete file)
|
8.40 KB,
patch
|
bzbarsky
:
review+
|
Details | Diff | Splinter Review |
|
8.86 KB,
patch
|
Details | Diff | Splinter Review |
Totally untested patch since I haven't figured out how to compile
Telephony.h/cpp
https://tbpl.mozilla.org/?tree=Try&rev=56fd506a31c1
But I'll test the changes to EventListenerManager tomorrow.
|
Assignee | |
Comment 1•12 years ago
|
||
https://tbpl.mozilla.org/?tree=Try&rev=883f84a58c57
Maybe this compiles
Attachment #753524 -
Attachment is obsolete: true
|
|
Assignee | |
Comment 2•12 years ago
|
||
Comment on attachment 753766 [details] [diff] [review]
v2
The ELM part is a bit ugly.
Attachment #753766 -
Flags: review?(bzbarsky)
|
||
Comment 3•12 years ago
|
||
Comment on attachment 753766 [details] [diff] [review]
v2
>+ bool same = scriptListener->GetHandler().Ptr() && aHandler.Ptr() &&
>+ scriptListener->GetHandler().Ptr()->CallbackPreserveColor() ==
>+ aHandler.Ptr()->CallbackPreserveColor();
Maybe put this in an operator== on nsEventHandler?
>+ void EventListenerAdded(nsIAtom* aType);
virtual, and MOZ_OVERRIDE.
r=me with that.
Attachment #753766 -
Flags: review?(bzbarsky) → review+
|
|
Assignee | |
Comment 4•12 years ago
|
||
|
||
Comment 5•12 years ago
|
||
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla24
You need to log in
before you can comment on or make changes to this bug.
Description
•