875599 - Delete dead code in tools repo

Status: RESOLVED FIXED

(Infrastructure & Operations Graveyard :: CIDuty, task)

Description

[Pete Moore [:pmoore][:pete]]

In tools repository, we have many scripts (and some files) both in sut_tools/ and buildfarm/mobile/ that we consider obsolete at this point, and can be removed, which cleans clutter.

Along this vein we have functions/classes that are also unused/dead.

All should be removed.

Comment 1

[Pete Moore [:pmoore][:pete]]

Attachment: Files for deletion

Please can you guys review to check I'm not ditching anything we need!

Thanks,
Pete

Comment 2

[Justin Wood (:Callek)]

Comment on attachment 753576 [details] [diff] [review]
Files for deletion

Review of attachment 753576 [details] [diff] [review]:
-----------------------------------------------------------------

f+, I half wrote this so official review to kim

Comment 3

[Kim Moir [:kmoir] ET]

Comment on attachment 753576 [details] [diff] [review]
Files for deletion

Ran it staging, lgtm

Comment 4

[Pete Moore [:pmoore][:pete]]

Cool, I'll land it! :)

Comment 5

[Pete Moore [:pmoore][:pete]]

landed: https://hg.mozilla.org/build/tools/rev/be4b476600b2

Comment 6

[Pete Moore [:pmoore][:pete]]

Attachment: Puppet changes due to deleted files - no need for symbolic links

On the foopies under /builds, we have symbolic links for

    start_cp.sh -> /builds/tools/buildfarm/mobile/start_cp.sh
    stop_cp.sh -> /builds/tools/buildfarm/mobile/stop_cp.sh

Removed this from the puppet config, since these files no longer exist, so no need for symbolic links.

Comment 7

[Justin Wood (:Callek)]

Comment on attachment 770684 [details] [diff] [review]
Puppet changes due to deleted files - no need for symbolic links

This doesn't actually remove the files, it just removes puppets management of the files.

What we want here is ensure => absent; and remove the other lines (owner, target, group)

And we should comment that its obsolete and then in a week or two fully delete the management of them from these manifests.

Comment 8

[Pete Moore [:pmoore][:pete]]

Hey Callek, somehow I only just spotted Comment 7 above, and the r-. It got checked in, as it was. If you want me to still add the ensure => absent, etc - please reopen the ticket, and I'll hop on it.

Not sure how I missed the r- there, apologies for this!
Pete

Comment 9

[Justin Wood (:Callek)]

(In reply to Pete Moore [:pete][:pmoore] from comment #8)
> Hey Callek, somehow I only just spotted Comment 7 above, and the r-. It got
> checked in, as it was. If you want me to still add the ensure => absent, etc
> - please reopen the ticket, and I'll hop on it.
> 
> Not sure how I missed the r- there, apologies for this!
> Pete

Indeed we should do the ensure => absent. Without that these links are still present on the foopies.

Comment 10

[Pete Moore [:pmoore][:pete]]

ok, i'm on it :)

Comment 11

[Pete Moore [:pmoore][:pete]]

Attachment: Puppet changes due to deleted files - no need for symbolic links

Comment 12

[Justin Wood (:Callek)]

Comment on attachment 817819 [details] [diff] [review]
Puppet changes due to deleted files - no need for symbolic links

Review of attachment 817819 [details] [diff] [review]:
-----------------------------------------------------------------

r- only for stylistic/organization reasons.

Can you stick that new piece down at http://mxr.mozilla.org/build/source/puppet/modules/foopy/manifests/init.pp#118 (and replace the ensure=>absent directives already there since we no longer need them defined)

Comment 13

[Pete Moore [:pmoore][:pete]]

Attachment: Puppet patch

Updated as per your review above.

Just testing this patch now on releng-puppet2.srv.releng.scl3.mozilla.com...

When I've finished testing, I'll update the bug.

Comment 14

[Pete Moore [:pmoore][:pete]]

Testing successful of foopy57 - broken links existed before test run, after executing puppet against my personal branch with this fix, the files were removed.

Comment 15

[Pete Moore [:pmoore][:pete]]

Committed and pushed:
    https://hg.mozilla.org/build/puppet/rev/375e41f40f49