Closed Bug 875599 Opened 9 years ago Closed 8 years ago

Delete dead code in tools repo

Categories

(Infrastructure & Operations Graveyard :: CIDuty, task)

x86
All
task
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: pmoore, Assigned: pmoore)

References

()

Details

Attachments

(2 files, 2 obsolete files)

In tools repository, we have many scripts (and some files) both in sut_tools/ and buildfarm/mobile/ that we consider obsolete at this point, and can be removed, which cleans clutter.

Along this vein we have functions/classes that are also unused/dead.

All should be removed.
Please can you guys review to check I'm not ditching anything we need!

Thanks,
Pete
Assignee: nobody → pmoore
Status: NEW → ASSIGNED
Attachment #753576 - Flags: review?(kmoir)
Attachment #753576 - Flags: review?(bugspam.Callek)
Comment on attachment 753576 [details] [diff] [review]
Files for deletion

Review of attachment 753576 [details] [diff] [review]:
-----------------------------------------------------------------

f+, I half wrote this so official review to kim
Attachment #753576 - Flags: review?(bugspam.Callek) → feedback+
Comment on attachment 753576 [details] [diff] [review]
Files for deletion

Ran it staging, lgtm
Attachment #753576 - Flags: review?(kmoir) → review+
Cool, I'll land it! :)
On the foopies under /builds, we have symbolic links for

    start_cp.sh -> /builds/tools/buildfarm/mobile/start_cp.sh
    stop_cp.sh -> /builds/tools/buildfarm/mobile/stop_cp.sh

Removed this from the puppet config, since these files no longer exist, so no need for symbolic links.
Attachment #770684 - Flags: review?(bugspam.Callek)
Comment on attachment 770684 [details] [diff] [review]
Puppet changes due to deleted files - no need for symbolic links

This doesn't actually remove the files, it just removes puppets management of the files.

What we want here is ensure => absent; and remove the other lines (owner, target, group)

And we should comment that its obsolete and then in a week or two fully delete the management of them from these manifests.
Attachment #770684 - Flags: review?(bugspam.Callek) → review-
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Product: mozilla.org → Release Engineering
Hey Callek, somehow I only just spotted Comment 7 above, and the r-. It got checked in, as it was. If you want me to still add the ensure => absent, etc - please reopen the ticket, and I'll hop on it.

Not sure how I missed the r- there, apologies for this!
Pete
Flags: needinfo?(bugspam.Callek)
(In reply to Pete Moore [:pete][:pmoore] from comment #8)
> Hey Callek, somehow I only just spotted Comment 7 above, and the r-. It got
> checked in, as it was. If you want me to still add the ensure => absent, etc
> - please reopen the ticket, and I'll hop on it.
> 
> Not sure how I missed the r- there, apologies for this!
> Pete

Indeed we should do the ensure => absent. Without that these links are still present on the foopies.
Status: RESOLVED → REOPENED
Flags: needinfo?(bugspam.Callek) → needinfo?(pmoore)
Resolution: FIXED → ---
ok, i'm on it :)
Flags: needinfo?(pmoore)
Attachment #770684 - Attachment is obsolete: true
Attachment #817819 - Flags: review?(bugspam.Callek)
Comment on attachment 817819 [details] [diff] [review]
Puppet changes due to deleted files - no need for symbolic links

Review of attachment 817819 [details] [diff] [review]:
-----------------------------------------------------------------

r- only for stylistic/organization reasons.

Can you stick that new piece down at http://mxr.mozilla.org/build/source/puppet/modules/foopy/manifests/init.pp#118 (and replace the ensure=>absent directives already there since we no longer need them defined)
Attachment #817819 - Flags: review?(bugspam.Callek) → review-
Attached patch Puppet patchSplinter Review
Updated as per your review above.

Just testing this patch now on releng-puppet2.srv.releng.scl3.mozilla.com...

When I've finished testing, I'll update the bug.
Attachment #817819 - Attachment is obsolete: true
Attachment #8375542 - Flags: review?(bugspam.Callek)
Attachment #8375542 - Flags: review?(bugspam.Callek) → review+
Testing successful of foopy57 - broken links existed before test run, after executing puppet against my personal branch with this fix, the files were removed.
Committed and pushed:
    https://hg.mozilla.org/build/puppet/rev/375e41f40f49
Status: REOPENED → RESOLVED
Closed: 9 years ago8 years ago
Resolution: --- → FIXED
Component: Platform Support → Buildduty
Product: Release Engineering → Infrastructure & Operations
Product: Infrastructure & Operations → Infrastructure & Operations Graveyard
You need to log in before you can comment on or make changes to this bug.