875756 - Implement <input type="color">: Mac OS X widget/color picker

Status: RESOLVED FIXED

(Core :: Widget: Cocoa, defect)

Comment 1

[Mounir Lamouri (:mounir)]

Attachment: Patch

Comment 2

[Steven Michaud [:smichaud] (Retired)]

I haven't yet looked closely at your patch, or tested it.

But it appears to use a synchronous native dialog in a separate (app-modal) window.  It should really use an asynchronous window-modal sheet.  Especially since nsIColorPicker appears to have support for asynchronous use (nsIColorPicker::open() has an aCallback parameter).

Comment 3

[Steven Michaud [:smichaud] (Retired)]

Actually this patch does seem to have some asynchronous elements, though I still think the native dialog needs to be a sheet.

I'll (probably) do my review and test sometime next week.

Comment 4

[Mounir Lamouri (:mounir)]

The native Cocoa color panel is not using a sheet. Native applications do not do that. I have no idea if that is doable but that would be at best odd to users I believe.

Comment 5

[Mounir Lamouri (:mounir)]

Attachment: Patch

Small update of patch to make it apply on current trunk.

Comment 6

[Mounir Lamouri (:mounir)]

Comment on attachment 790790 [details] [diff] [review]
Patch

Trying some alternative reviewers given that Steven seems to have a few reviews in his queue.

Comment 7

[Markus Stange [:mstange]]

Comment on attachment 790790 [details] [diff] [review]
Patch

Looks good except for some style issues.

> - (id) initWithPicker:(nsColorPicker*)aPicker;
        ^ no space here (+ similar occurrences)

>   return [NSColor colorWithDeviceRed: red green: green blue: blue alpha: 1.0];
                                       ^ no space here (+ similar occurrences)

>  [mColorPanel open:GetNSColorFromHexString(mColor)
>               title: nsCocoaUtils::ToNSString(mTitle)];
                    ^ align at colon, no space

Please add a new line at the end of both files.

For the hex to NSColor conversion, I'd prefer something that uses NSScanner, similarly to http://www.karelia.com/cocoa_legacy/Foundation_Categories/NSColor__Instantiat.m
But it's not important.

Also, you should probably combine the four NSString stringWithFormat invocations into one with format string @"#%02x%02x%02x".

Comment 8

[Benoit Girard (:BenWa)]

Comment on attachment 790790 [details] [diff] [review]
Patch

Review of attachment 790790 [details] [diff] [review]:
-----------------------------------------------------------------

I did a quick look nothing jumped out at me, except maybe that I'm sure we have a viable implementation of hex->int we could reuse.

Markus' review is enough.

Comment 9

[Mounir Lamouri (:mounir)]

Attachment: Patch

Comment 10

[Mounir Lamouri (:mounir)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/119f97559386

Comment 11

[Mounir Lamouri (:mounir)]

(In reply to Benoit Girard (:BenWa) from comment #8)
> Comment on attachment 790790 [details] [diff] [review]
> Patch
> 
> Review of attachment 790790 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> I did a quick look nothing jumped out at me, except maybe that I'm sure we
> have a viable implementation of hex->int we could reuse.

My method is using NSString and I guess converting to nsString would not be worth it.

Comment 12

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/119f97559386