875907 - Mi Movistar app for Spain is not the correct one

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia, defect, P1)

Description

[David Palomino [:dpalomino]]

Ikura, AU116, 24/05 vendor build

MiMovistar app is not the right one. 

Please, Karen, could you please take a look on this? Could you check it for both Spain and Latam versions?

Thanks!
David

Comment 1

[Jason Smith [:jsmith]]

Can you give a copy of the actual app that should be on device? Or point to a location I could look at to see it?

Comment 2

[Daniel Coloma:dcoloma]

Available in the marketplace:
https://marketplace.firefox.com/app/mi-movistar?src=search

Manifest:
www.movistar.es/atcliente/MiMovistar/Pandora/manifest.webapp

That points to:
http://www.movistar.es/atcliente/MiMovistar/Pandora/

Comment 3

[Jason Smith [:jsmith]]

(In reply to Daniel Coloma:dcoloma from comment #2)
> Available in the marketplace:
> https://marketplace.firefox.com/app/mi-movistar?src=search
> 
> Manifest:
> www.movistar.es/atcliente/MiMovistar/Pandora/manifest.webapp
> 
> That points to:
> http://www.movistar.es/atcliente/MiMovistar/Pandora/

Okay, so Spain looks right to me in the customization for spain:

https://github.com/telefonicaid/firefoxos-gaia-spain/tree/master/external-apps/mimovistar

Which uses:

http://www.movistar.es/atcliente/MiMovistar/Pandora/manifest.webapp

Latam is not using that app. It's using a packaged app:

https://github.com/telefonicaid/firefoxos-gaia-latam/tree/master/external-apps/mimovistar

The grid I'm seeing says that for latam, it's supposed to be a packaged Mi Movistar app.

So what's the bug here?

Comment 4

[Karen Ward [:kward]]

I agree with Jason's assessment.  Yuren, please confirm.

Comment 5

[Daniel Coloma:dcoloma]

  - Mi Movistar for LatAm is a packaged app. Customisation in https://github.com/telefonicaid/firefoxos-gaia-latam/ is correct and applying this customisation is working properly. This app runs inside a wrapper (ala everything.me)
  - Mi Movistar for Spain is a hosted app. Customisation in https://github.com/telefonicaid/firefoxos-gaia-spain is wrong as it includes two files that should not be there (application.zip and update.webapp) as they are part of the LatAm packaged. Applying Spain customisation results in the LatAm app applied. E.g. If you click on MiMovistar you see a wrapper that should not be shown in this case.

Removing those two files from Spain repository solves the issue. I've tested locally in an Unagi and that solved the issue for me. We need to do it in the repository, Yuren, are you planning to do it or should I do it?

Comment 6

[Yuren [:yurenju] (AFK ~ Oct. 12) (volunteer mode)]

I'll do it today

Comment 8

[Jason Smith [:jsmith]]

(In reply to Daniel Coloma:dcoloma from comment #5)
>   - Mi Movistar for LatAm is a packaged app. Customisation in
> https://github.com/telefonicaid/firefoxos-gaia-latam/ is correct and
> applying this customisation is working properly. This app runs inside a
> wrapper (ala everything.me)
>   - Mi Movistar for Spain is a hosted app. Customisation in
> https://github.com/telefonicaid/firefoxos-gaia-spain is wrong as it includes
> two files that should not be there (application.zip and update.webapp) as
> they are part of the LatAm packaged. Applying Spain customisation results in
> the LatAm app applied. E.g. If you click on MiMovistar you see a wrapper
> that should not be shown in this case.
> 
> Removing those two files from Spain repository solves the issue. I've tested
> locally in an Unagi and that solved the issue for me. We need to do it in
> the repository, Yuren, are you planning to do it or should I do it?

Ah, that makes sense. I had a bug on file for this in the dupe here on 5/9/2013.

Comment 9

[Yuren [:yurenju] (AFK ~ Oct. 12) (volunteer mode)]

Attachment: pull request: https://github.com/telefonicaid/firefoxos-gaia-spain/pull/29

Comment 10

[Jason Smith [:jsmith]]

Comment on attachment 754215 [details] [review]
pull request: https://github.com/telefonicaid/firefoxos-gaia-spain/pull/29

lgtm. Up to you if you want to wait for an additional review here or we can land this right now.

Comment 11

[Daniel Coloma:dcoloma]

Merged

https://github.com/telefonicaid/firefoxos-gaia-spain/commit/b85b7922dce178e74a853e2274c66b055b8351d6