875937 - Defect - App bar pin tile icon refreshes after it is displayed instead of before

Status: VERIFIED FIXED

(Firefox for Metro Graveyard :: Browser, defect, P3)

Description

[Brian R. Bondy [:bbondy]]

1. Select a tile and pin it.
2. Select a different tile that is unpinned, notice that pin icon shows up.
3. Unselect that tile
4. Select the tile that was previously pinned

Actual results: You'll see the appbar come up with the pin icon, and then after it is up it changes to the unpin icon
Expected result: It should just show the unpin icon right away and not change after it has come up.

Comment 1

[Brian R. Bondy [:bbondy]]

p=1

Comment 2

[Kamil Jozwiak [:kjozwiak]]

Attachment: fixes the pin issue

other than some automated tests, this is my first patch that seems to fix the problem described by Brian in comment 0

Comment 3

[Matt Brubeck (:mbrubeck)]

Comment on attachment 776898 [details] [diff] [review]
fixes the pin issue

Review of attachment 776898 [details] [diff] [review]:
-----------------------------------------------------------------

Looks great.  Thanks!

::: browser/metro/base/content/appbar.js
@@ +159,5 @@
>    },
>  
>    showContextualActions: function(aVerbs) {
> +    // When the appbar is not visible, we want the icons to refresh right away
> +    var immediate = !Elements.contextappbar.isShowing;

nit: Please use "let" instead of "var".

Comment 4

[Kamil Jozwiak [:kjozwiak]]

Attachment: fixes the pin issue v2

fixed the small nit mentioned in comment 3

Comment 5

[Brian R. Bondy [:bbondy]]

\o/ :D Nice job!

I pushed to try here:
https://tbpl.mozilla.org/?tree=Try&rev=c070a75e1da0

This will run through the metro tests to make sure nothing got broken in the tests or the app. 

I'll check if that passes tomorrow and if so I'll push it over to mozilla-central.

Comment 6

[Kamil Jozwiak [:kjozwiak]]

Thanks Brian! Appreciate it

Comment 7

[Brian R. Bondy [:bbondy]]

All green, nice job!
https://hg.mozilla.org/integration/mozilla-inbound/rev/0f7bf77ccafb

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/0f7bf77ccafb

Comment 9

[Manuela Muntean [Away]]

Mozilla/5.0 (Windows NT 6.2; rv:25.0) Gecko/20130728 Firefox/25.0

Verified as fixed on the latest Nightly build using the steps from the description.