876174 - On Win7/8 show the correct inverted icons

Status: RESOLVED FIXED

(Calendar :: General, defect)

Description

[Richard Marti (:Paenglab)]

On Win 8 the non-inverted icons are used for the tab-bar. Bug 875472 for TB changes them to the inverted like IE 10 is using them.
Also when using a persona the TB own icons are shown instead the Lightning icons.
On Win7/8 with a light persona the icons on tab-bar will be the non-inverted icons like on the main toolbar.

Comment 1

[Richard Marti (:Paenglab)]

Attachment: patch

Fix the issues.

Comment 2

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

Comment on attachment 754161 [details] [diff] [review]
patch

Review of attachment 754161 [details] [diff] [review]:
-----------------------------------------------------------------

::: calendar/base/themes/windows/win-aero/lightning-toolbar.css
@@ +72,5 @@
> +#mail-bar3:-moz-lwtheme-brighttext #lightning-button-calendar,
> +#mail-bar3:-moz-lwtheme-brighttext #lightning-button-tasks,
> +#tabbar-toolbar:-moz-lwtheme-brighttext #lightning-button-calendar,
> +#tabbar-toolbar:-moz-lwtheme-brighttext #lightning-button-tasks {
> +  list-style-image: url(chrome://lightning/skin/mode-switch-icons-inverted.png);

No more !important needed?

Comment 3

[Richard Marti (:Paenglab)]

(In reply to Philipp Kewisch [:Fallen] from comment #2)
> 
> No more !important needed?

The !important is no more needed. Also tested without patch from bug 875472.

Comment 4

[Richard Marti (:Paenglab)]

Pushed to comm-central: http://hg.mozilla.org/comm-central/rev/7a8a2adbfccc

Comment 5

[Stefan Sitter [:ssitter]]

Could you attach a screenshot, so that we testers know what is considered wrong display and what is considered correct display?

Comment 6

[Richard Marti (:Paenglab)]

Attachment: screenshot before patch

The buttons in the toolbar below have the wrong icons. Placed in the tabs-toolbar they become again the correct icons like the fixed buttons you can see on top in this image.