876185 - messageInjection.js: add_sets_to_folders: messageSet is not defined (line 713)

Status: RESOLVED FIXED

(Thunderbird :: Testing Infrastructure, defect)

Description

[Jens Müller (:tessarakt)]

See https://bugzilla.mozilla.org/show_bug.cgi?id=876089#c18

I do not trigger the exception any longer.

A number of tests call the function, but none causes this problem. Maybe none of them triggers the relevant codepath.

Comment 1

[:aceman]

Yes, while the error is not seen in any test logs, the problem can be confirmed just by reading the code. messageSet is a local (let) variable used above this line, but does not exist at this point.

Comment 2

[:aceman]

This seems to be caused by bug 588048, where the junk and read state was moved out of the loop having messageSet into a new loop where it is not set.

Comment 3

[:aceman]

Bug 588048 probably got away with this because there seem to be no users of the junk/read functionality...

Comment 4

[:aceman]

Attachment: patch

So here is some tweak so that those operations could work if needed.

Comment 5

[Andrew Sutherland [:asuth] (he/him)]

Comment on attachment 760208 [details] [diff] [review]
patch

(I no longer have review authority)

Comment 6

[:aceman]

Comment on attachment 760208 [details] [diff] [review]
patch

So feedback would be enough. I have chosen you personally to look at this because you seem to have introduced the error so maybe you know if this will fix it.

Comment 7

[Andrew Sutherland [:asuth] (he/him)]

Comment on attachment 760208 [details] [diff] [review]
patch

Looks correct, like the cleanup on centralizing things in the message set.  Thanks for cleaning up my old breakage!

Comment 8

[Mike Conley (:mconley) (:⚙️)]

Comment on attachment 760208 [details] [diff] [review]
patch

Yep, I'm fine with this. Thanks aceman!

Comment 9

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/comm-central/rev/ee851dac3887