876191 - Defect - Two spaces between "the" & "nightly" under the "About" flyout

Status: VERIFIED FIXED

(Firefox for Metro Graveyard :: Flyouts, defect, P2)

Description

[Kamil Jozwiak [:kjozwiak]]

Attachment: two spaces instead of one (doesn't look consistent)

This is pretty trivial but there are two spaces between "the" & "nightly" under the "About" flyout. Its not consistent and it looks a little off when you see two spaces between the two words instead of one.

I also think that "nightly" should be changed to "Nightly" to keep it consistent throughout the flyouts.

I attached a screenshot to illustrate the two spaces. (the gap is wider between "the" & "nightly" compared to the rest of the sentence)

Steps to reproduce the issue:

1) Open Firefox Metro
2) Swipe the "App Bar" and select "Settings" and then "About"

Current Behavior:

- You will notice a wider gab between "the" & "nightly"

Expected Behavior:

- Gap should be the same size as the others, would look nicer if "nightly" was changed to "Nightly"

Comment 1

[Brian R. Bondy [:bbondy]]

p=1

Comment 2

[Brian R. Bondy [:bbondy]]

Attachment: Patch v1.

This just copies the same desktop firefox style for #currentChannel

Comment 3

[Allison Naaktgeboren :ally]

Comment on attachment 755140 [details] [diff] [review]
Patch v1.

Review of attachment 755140 [details] [diff] [review]:
-----------------------------------------------------------------

lgtm.

Kamil, I know the lower case 'nightly' is incorrect grammar, but I notice that on my desktop aurora has the same issue: "You are currently on the aurora update channel". For now, it is parity, and I'd bet it has something to do with localization.

Comment 4

[Brian R. Bondy [:bbondy]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/666e862aaac3

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/666e862aaac3

Comment 6

[Marco Mucci [:MarcoM]]

For testing and verification.

Comment 7

[Kamil Jozwiak [:kjozwiak]]

Went through the following "Defect" for Testing & Verification without any issues. Used the following build:

http://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/2013-06-01-03-09-38-mozilla-central/

- Ensured that the two spaces have been removed and the formatting looks correct throughout the "About" flyout
- Ensured that the "nightly" is not capitalized as per Comment 3 (it's in parity with other release channels as Ally mentioned)
- Ensured that the "About" flyout worked without any issues
- Ensured that the "Read the Nightly privacy online" link worked without any issues
- Ensured that the above test cases also work in Filled View

Comment 8

[Kamil Jozwiak [:kjozwiak]]

Went through the following "Defect" for iteration #8 testing without any issues. Used the following build:

http://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/2013-06-10-03-11-47-mozilla-central/

- Went through the original test cases from Comment 0 without any issues
- Went through the test cases from Comment 7 without any issues

Comment 9

[Kamil Jozwiak [:kjozwiak]]

Went through the following "Defect" for iteration #9 testing without any issues. Used the following build:

http://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/2013-06-25-03-12-38-mozilla-central/

- Went through the original test case added in comment 0 without any issues
- Went through the test cases from comment 7 without any issues
- Ensured that the correct version # & date is being listed under the "About" flyout

Comment 10

[Kamil Jozwiak [:kjozwiak]]

Went through the following "Defect" for iteration #10 testing without any issues. Used the following build:

http://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/2013-07-19-03-02-04-mozilla-central/

- Went through the original test case added in comment 0 without any issues
- Went through the test cases from comment 7 without any issues
- Ensured that the correct version # & date is being listed under the "About" flyout

Comment 11

[Kamil Jozwiak [:kjozwiak]]

Went through the following "Defect" for iteration #12 testing without any issues. Used the following build:

http://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/2013-08-20-03-02-06-mozilla-central/

- Went through the original test case added in comment 0 without any issues
- Went through the test cases from comment 7 without any issues
- Ensured that the correct version # & date is being listed under the "About" flyout