876566 - ./mach build toolkit/library/ builds xul.dll even if nothing has changed.

Status: RESOLVED DUPLICATE of bug 867807

(Firefox Build System :: General, defect)

Description

[Chris Pearce [:cpearce (Not reading bugmail)]]

STR:
Run the following command on Windows:
./mach build toolkit/library/ && ./mach build toolkit/library/

Note that xul.dll is built twice, even though no other modules changed between the first and second builds.

This seems to be a recent (i.e. in the past few months) change in behaviour.

Comment 1

[Chris Pearce [:cpearce (Not reading bugmail)]]

My .mozconfig:

mk_add_options MOZ_OBJDIR=@TOPSRCDIR@/objdir
ac_add_options --enable-tests
ac_add_options --enable-debug
mk_add_options MOZ_MAKE_FLAGS="-j9 -s"
ac_add_options --disable-optimize
mk_add_options AUTOCLOBBER=1

Comment 2

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

What does `make` do?

Comment 3

[(not currently active) Ted Mielczarek]

`make -C $objdir/toolkit/library`, specifically. This is almost certainly a build system bug and not a mach bug.

Comment 4

[Chris Pearce [:cpearce (Not reading bugmail)]]

Attachment: output of `build/pymake/make.py -C objdir/toolkit/library/`

Here's the output of `build/pymake/make.py -C objdir/toolkit/library/`. Regular `make` no longer works on Windows. This output is the same every time I run it, i.e. xul.dll is being rebuilt every time I build toolkit/library with pymake too.

Comment 5

[Mike Hommey [:glandium]]

Might be related to bug 874543

Comment 6

[Mark Hammond [:markh] [:mhammond]]

See also bug 867807 - if the DirectX SDK is installed in a directory with spaces (eg, under "c:\Program Files (x86)", this bug is a symptom.  Can anyone here reproduce the bug when that is *not* the case?  If not, we probably have a dupe.

Comment 7

[Jared Wein [:jaws] (please needinfo? me)]

I ran in to this bug and had spaces in my DirectX SDK path. This bug no longer happens after I moved my DirectX SDK installation path.