924676 - mach builds xul lib when only building a tests subdir in a module

Status: NEW

(Firefox Build System :: General, defect)

Description

[Honza Bambas (:mayhemer)]

e.g. ./mach build content/events/test/ builds xul.dll, but there are just tests.

Some time ago building any subdirs started to also run xul lib rebuild automatically.  Before that xul lib was built only when a top level module (e.g. /content, /network) was build.  

This new behavior is kinda annoying.

Is there an option or can this 'feature' be removed?  To have a separate |mach xul| command would also be good, btw.

Comment 1

[Matt Brubeck (:mbrubeck)]

This is an (intentional but suboptimal) change caused by bug 869613.  As a workaround, you can use "mach build -X" (or "--disable-extra-make-dependencies") to disable this behavior.

It would be nice if we had a way detect or specify directories that do *not* depend on toolkit/library (or more generally, to limit dumbmake dependency "inheritance" by subdirectory).

Comment 2

[Mike Hommey [:glandium]]

I think that now there's mach build binaries, we should kill dumbmake.

Comment 3

[(no longer active)]

(In reply to comment #2)
> I think that now there's mach build binaries, we should kill dumbmake.

We should wait until the rough edges are ironed out.  I have yet to be able to do a full ./mach build binaries which gives me a new libxul.  :(

Comment 4

[Matt Brubeck (:mbrubeck)]

(In reply to :Ehsan Akhgari (needinfo? me!) from comment #3)
> (In reply to comment #2)
> > I think that now there's mach build binaries, we should kill dumbmake.
> 
> We should wait until the rough edges are ironed out.

(including "does not work on Windows")

Comment 5

[Honza Bambas (:mayhemer)]

(In reply to Matt Brubeck (:mbrubeck) from comment #4)
> (including "does not work on Windows")

Cool :)  I feel so lucky...  why is windows so hard to make work all the time...?