981646 - B2G RIL: Cannot read sdn contacts

Status: RESOLVED FIXED

(Firefox OS Graveyard :: RIL, defect)

Description

[Francisco Jordano [:arcturus] [:francisco]]

Cannot read sdn contacts from Gaia.

When executing the following code:

// Assuming icc is a valid instance of MozIcc
var request = icc.readContacts('sdn');

We get the following error on the request:
DOMError {name: "ContactTypeNotSupported", message: ""}

We performed the test against a SIM we checked previously that contains sdn contacts. Perhaps are we not using the correct api for reading the sdn contacts?

Comment 1

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

SDN is not supported yet.

Comment 2

[Jose Manuel Cantera]

(In reply to Yoshi Huang[:allstars.chh] from comment #1)
> SDN is not supported yet.

Yoshi,

Do we have an estimation on when this feature would be ready?

thanks!

Comment 3

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

I could work on it, but I have some other bugs ongoing right now, I will try to land it before 4/4, is it okay for you?

Comment 4

[Jose Manuel Cantera]

I don't know the proper timeframe for this and the committments. Asking Noemi and Wilfred

Comment 5

[Noemí Freire (:noemi)]

(In reply to Jose M. Cantera from comment #4)
> I don't know the proper timeframe for this and the committments. Asking
> Noemi and Wilfred

I'd say, please land when ready, 4/4 would be fine to have gecko part in order to allow us to work on gaia side during v1.5 development timeframe.

Comment 6

[Joe Cheng [:jcheng] (please needinfo)]

Wesley, this is a targeted feature in 1.5 for comms, can RIL team consider this as targeted 1.5 feature? thanks

Comment 7

[Ken Chang[:kenkai]]

sure, nominate it as 1.5? for tracking.

Comment 8

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

This is not 1.5?

Comment 9

[Ken Chang[:kenkai]]

Set target milestone instead.

Comment 10

[Wilfred Mathanaraj [:WDM]]

Comms import/export should work on it when RIL team is done - and it should as Noemi says land when ready.

Comment 11

[Ken Chang[:kenkai]]

Put this bug into backlog.

Comment 12

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

Attachment: Patch.

Comment 13

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

Attachment: Patch

Comment 14

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

Comment on attachment 8423705 [details] [diff] [review]
Patch.

Obsolete this patch, since it comes with DEBUG=true.

Comment 15

[Vicamo Yang [:vicamo][:vyang]]

Comment on attachment 8423757 [details] [diff] [review]
Patch

Review of attachment 8423757 [details] [diff] [review]:
-----------------------------------------------------------------

Thank you!

Comment 16

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

Comment on attachment 8423757 [details] [diff] [review]
Patch

Review of attachment 8423757 [details] [diff] [review]:
-----------------------------------------------------------------

r? to smaug for the WebIDL change.

Hi smaug
I update the comments in readContacts from MozIcc.webidl.

Can you help to review this ?

Thanks

Comment 17

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

Attachment: Patch. v2

rebase and add r=smaug

Comment 18

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

https://hg.mozilla.org/integration/b2g-inbound/rev/8324609dcb77

Comment 19

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/8324609dcb77