876774 - [SMS] Thread List should find contact if thread has non-internationalized number

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::SMS, defect)

Description

[Corey Frang [:gnarf]]

Steps to Reproduce:

* Create a contact and store an internationalized number I.E. [phone]
* Goto SMS App, make sure no thread with this contact exists
* Send SMS to non-internationalized number I.E. 8155551212 - ignore the contact it is suggesting.

Expected:
* Finds the internationalized contact and shows the name correctly

Actual:
* Displays the phone number without prefix, doesn't find contact

Interestingly:
* The contact suggestion pane finds the number while you are typing.

Comment 1

[Corey Frang [:gnarf]]

Note, the opposite is also true - The thread list will not find the contact if the non-internationalized number is stored.

Comment 2

[Dietrich Ayala (:dietrich)]

Regression landing with MMS changes, going to fix after merge.

Comment 3

[:gerard-majax]

I'll try to have a look on this one.

Comment 4

[:gerard-majax]

Bug 862250 introduced a telMatch index for this purpose, but it's not being used by the SMS app.

Comment 5

[:gerard-majax]

(In reply to Corey Frang [:gnarf] [:gnarf37] from comment #0)
> Steps to Reproduce:
> 
> * Create a contact and store an internationalized number I.E. [phone]
> * Goto SMS App, make sure no thread with this contact exists
> * Send SMS to non-internationalized number I.E. 8155551212 - ignore the
> contact it is suggesting.
> 
> Expected:
> * Finds the internationalized contact and shows the name correctly
> 
> Actual:
> * Displays the phone number without prefix, doesn't find contact
> 
> Interestingly:
> * The contact suggestion pane finds the number while you are typing.

I've checked, and it seems like the matching is working, I have my cell registered as +336xxx number in a contact, and when I try to send a SMS, typing 06xxx shows my contact.

However, there is no highlight on the number. Is it the bug you spotted ?

Comment 6

[:gerard-majax]

(In reply to Alexandre LISSY :gerard-majax from comment #5)
> (In reply to Corey Frang [:gnarf] [:gnarf37] from comment #0)
> > Steps to Reproduce:
> > 
> > * Create a contact and store an internationalized number I.E. [phone]
> > * Goto SMS App, make sure no thread with this contact exists
> > * Send SMS to non-internationalized number I.E. 8155551212 - ignore the
> > contact it is suggesting.
> > 
> > Expected:
> > * Finds the internationalized contact and shows the name correctly
> > 
> > Actual:
> > * Displays the phone number without prefix, doesn't find contact
> > 
> > Interestingly:
> > * The contact suggestion pane finds the number while you are typing.
> 
> I've checked, and it seems like the matching is working, I have my cell
> registered as +336xxx number in a contact, and when I try to send a SMS,
> typing 06xxx shows my contact.
> 
> However, there is no highlight on the number. Is it the bug you spotted ?

Okay sorry, I re-read, and I have worse when reproducing: even entering the internationalized version, it does not identify the contact when I ignore the suggestion.

Comment 7

[:gerard-majax]

According to https://www.dropbox.com/s/mrtjwvzk6xgoc02/HTML5_SMS-MMSUserStorySpecifications_20130503_V8.0.pdf page 7, we should only suggest according to contact names (first, last, etc.). There is no mention of using the phone number for this.

What should we do for this ?

Comment 8

[:gerard-majax]

Ayman, what should we do with this ?

Comment 9

[Julien Wajsberg [:julienw]]

In other words, should we remove the "search by phone number" ? Would fix Bug 876861 too, but I think we added it for some reason in the first time...

Comment 10

[Corey Frang [:gnarf]]

(In reply to Alexandre LISSY :gerard-majax from comment #5)
> (In reply to Corey Frang [:gnarf] [:gnarf37] from comment #0)
> > Steps to Reproduce:
> > 
> > * Create a contact and store an internationalized number I.E. [phone]
> > * Goto SMS App, make sure no thread with this contact exists
> > * Send SMS to non-internationalized number I.E. 8155551212 - ignore the
> > contact it is suggesting.
> > 
> > Expected:
> > * Finds the internationalized contact and shows the name correctly
> > 
> > Actual:
> > * Displays the phone number without prefix, doesn't find contact
> > 
> > Interestingly:
> > * The contact suggestion pane finds the number while you are typing.
> 
> I've checked, and it seems like the matching is working, I have my cell
> registered as +336xxx number in a contact, and when I try to send a SMS,
> typing 06xxx shows my contact.
> 
> However, there is no highlight on the number. Is it the bug you spotted ?

No, the Contact Suggestion works - it's the thread list view that can't find your internationalized contact after you send a message.

Comment 11

[:gerard-majax]

(In reply to Corey Frang [:gnarf] [:gnarf37] from comment #10)
> (In reply to Alexandre LISSY :gerard-majax from comment #5)
> > (In reply to Corey Frang [:gnarf] [:gnarf37] from comment #0)
> > > Steps to Reproduce:
> > > 
> > > * Create a contact and store an internationalized number I.E. [phone]
> > > * Goto SMS App, make sure no thread with this contact exists
> > > * Send SMS to non-internationalized number I.E. 8155551212 - ignore the
> > > contact it is suggesting.
> > > 
> > > Expected:
> > > * Finds the internationalized contact and shows the name correctly
> > > 
> > > Actual:
> > > * Displays the phone number without prefix, doesn't find contact
> > > 
> > > Interestingly:
> > > * The contact suggestion pane finds the number while you are typing.
> > 
> > I've checked, and it seems like the matching is working, I have my cell
> > registered as +336xxx number in a contact, and when I try to send a SMS,
> > typing 06xxx shows my contact.
> > 
> > However, there is no highlight on the number. Is it the bug you spotted ?
> 
> No, the Contact Suggestion works - it's the thread list view that can't find
> your internationalized contact after you send a message.

Thanks for the clarification, I know understand what you reported :). And I've been able to reproduce :)

Comment 12

[:gerard-majax]

Attachment: Link to Github https://github.com/mozilla-b2g/gaia/pull/10106

Please find the link to the Github pull request https://github.com/mozilla-b2g/gaia/pull/10106 that fixes this issue.

Comment 13

[:gerard-majax]

Comment on attachment 755856 [details]
Link to Github https://github.com/mozilla-b2g/gaia/pull/10106

><html>
>  <head>
>    <meta http-equiv="Refresh"
>    content="2; url=https://github.com/mozilla-b2g/gaia/pull/10106" />
>  </head>
>  <body>
>    Redirect to pull request #10106
>  </body>
></html>

Comment 14

[Julien Wajsberg [:julienw]]

Comment on attachment 755856 [details]
Link to Github https://github.com/mozilla-b2g/gaia/pull/10106

works perfect
r=me

Comment 15

[Julien Wajsberg [:julienw]]

master: 9f4237a7fffd852702d3997bf2724c3e71c8a5db

I think this fixes other bugs too, will try to dupe them.

clearing need info because it wasn't the purpose of this bug after all, but we'll need to ask maat for this though

Comment 18

[John Ford [:jhford] CET/CEST Berlin Time]

Uplifted 9f4237a7fffd852702d3997bf2724c3e71c8a5db to:
v1-train: ae284cb689d2b74541e741d39b9773ca7c2913f9

Comment 19

[:gerard-majax]

(In reply to Corey Frang [:gnarf] [:gnarf37] from comment #1)
> Note, the opposite is also true - The thread list will not find the contact
> if the non-internationalized number is stored.

I've been looking at this counterpart now that the bug is fixed, and it might still happen in some corner cases (never had a SIM card in the phone, things like this).