876891 - [keyboard] space should not automatically be inserted for username fields requiring email addresses

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Keyboard, defect)

Description

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

gaia : commit 6b75dbb7888acc7d094ae60c0302df7d49e056d7
Nightly/Master/MC
Unagi

1. go to contacts
2. go to settings
3. select Facebook Sync
4. type in . in the field.

Expected: no space is auto inserted
Actual: space is auto inserted

Note:
when you delete after you have a bunch of stuff already it starts wigging out something severe.

Comment 1

[Matěj Cepl]

And to the hostnames ... there is really no server 'luther. ceplovi. cz' ... I have spent an hour fighting Email account setting dialog before I got it by looking at the server email logs. How in the world should "normal users" know it without I don't know. This is really Mr. Clippy redivivus.

Comment 2

[David Flanagan [:djf]]

In part this is an evangalism bug: Facebook should use type=email in their field to prevent auto-corrections from happening there.

But there is also a bug in the auto-correction code. It should not automatically insert a space after punctuation when doing corrections.

Naoki: I can't reproduce exactly as you've specified.  I see an emtpy field and if I type . I just get .  But I do get ". " if it is after a word that is autocorrected.  Also, I've got not idea what you mean by "wigging out".

Comment 3

[David Flanagan [:djf]]

This bug is fixed by the patch attached to bug 878387.

Comment 4

[David Flanagan [:djf]]

Bug 878387 landed, so marking this bug fixed.

Comment 5

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

Yes, DJF, ". " was what I was referring to.  By "Wigging out" I mean I hit the delete, and it deletes 2 words instead of the space.  I can't seem to reproduce it consistantly.  I'll work on STRs and report as a separate bug if I still see it.

Comment 6

[:CSchmoeckel]

Spaces are no longer being added when entering characters into username and password fields (tested in E-Mail Account Setup). 
Tested on b2g/nightly/mozilla-central-unagi/latest

Kernel Date: Dec 5
Gecko: http://hg.mozilla.org/mozilla-central/rev/3c6f2394995d
Gaia: d2ad0f1a5a6be8a2d6df721ba3c2b33e037c423b

Comment 7

[Tony Chung [:tchung]]

Please add a testcase for this bug to moztrap for 1.1 testsuite.  If yes, mark this in-moztrap+ when completed.  If not, mark this in-moztrap-.

Comment 8

[David Flanagan [:djf]]

Uplifted to v1-train in bug 873934

Comment 9

[:CSchmoeckel]

Added Keyboard Suite Test Case #8472 - [Keyboard] A space is not added following a period mark while entering text in the username and password fields