878387 - [keyboard] minimize deletions and insertions for corrections

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Keyboard, defect)

Description

[David Flanagan [:djf]]

If we can't get bug 861515 uplifted to v1-train, then we should modify the auto-correction algorithm to minimize the backspaces and characters it needs to send to do a correction. Currently we backspace all the way to the start of the word and re-type it with a correction. But we should only backspace as far as the first changed letter. This should make a noticeable difference in the perceived speed of the corrections.

I've also seen a suggestion (but can't find the bug now that suggested it) that we use the MozKeyboard API function for setting a selection region instead of backspacing. I don't know if that is implemented. If so, then I should use that.

Comment 1

[Jan Jongboom [:janjongboom] (inactive)]

We can't use the selection range in v1-train afaik. Is not in b2g18.

Comment 2

[David Flanagan [:djf]]

Attachment: link to patch on github

Jan,

This is the bug we discussed by email. The patch also fixes two related bugs: 878168 and 876891.

Comment 3

[Jan Jongboom [:janjongboom] (inactive)]

I added some comments on the GH PR.

Comment 4

[Jan Jongboom [:janjongboom] (inactive)]

Attachment: Github PR that uses replaceSurroundingText

Use replaceSurroundingText is even faster, yay!

Comment 5

[Jan Jongboom [:janjongboom] (inactive)]

r=me. Landed in https://github.com/mozilla-b2g/gaia/commit/6ca1a9b1f327047697ab409e7e13bccd1d0a887a

Comment 6

[:CSchmoeckel]

Auto Correction has been updated so that pressing delete only once after an auto correction returns user to the place they were when Auto Correction was performed. It is now much easier and quicker to correct an Auto Correction mistake. 
Tested on b2g/nightly/mozille-central-unagi/latest.

Kernel Date: Dec 5
Gecko: http://hg.mozilla.org/mozilla-central/rev/3c6f2394995d
Gaia: d2ad0f1a5a6be8a2d6df721ba3c2b33e037c423b

Comment 7

[Tony Chung [:tchung]]

Please add a testcase for this bug to moztrap for 1.1 testsuite.  If yes, mark this in-moztrap+ when completed.  If not, mark this in-moztrap-.

Comment 8

[David Flanagan [:djf]]

Uplifted to v1-train in bug 873934

Comment 9

[:CSchmoeckel]

Minimalized deletions for Auto Correct is tested in Keyboard Suite Test Case #8446 - [Keyboard] Pressing the Backspace button immediately after a word suggestion reverts the changes