877255 - [calendar] Day view: 'All day' label not shown if there is an all day event in a disabled calendar

Status: RESOLVED DUPLICATE of bug 982240

(Firefox OS Graveyard :: Gaia::Calendar, defect)

Description

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Boot2Gecko 1.1.0.0-prerelease 20130528230207 on Unagi

Day view: 'All day' label not shown if there is an all day event in a disabled calendar

Steps to reproduce:
1. Open calendar. You should just have the Offline calendar.
2. Create a new all day event.
3. Open the Offline calendar
4. Go to Day view.
5. Go to the day of the all day event.

Actual result:
'All day' label on top is missing, but you can find it on the other days.

Comment 1

[Jason Smith [:jsmith]]

Confirmed, although I've only seen this when all calendars are disabled. Minor bug overall.

Comment 3

[Jason Smith [:jsmith]]

Not a regression - not blocking.

Comment 4

[buri.blff]

I found this problem due to the follow code in calender_color.js ln159 ~ ln163.        

        if (!calendar.localDisplayed) {
          displayBlock += '{ display: none; }';
        } else {
          displayBlock += '{ display: inherit; }';
        }

Comment 5

[Miller Medeiros [:millermedeiros]]

"All Day" is also considered an "hour" by the calendar view code, so fixing Bug 982240 will also fix this. I'm assigning this bug to myself since I need to add a test to confirm this behavior and avoid regressions. (I did not write tests for "all day" so far").

Comment 6

[Miller Medeiros [:millermedeiros]]

sorry, marked as a duplicate by mistake.. reopening it.

Comment 7

[Miller Medeiros [:millermedeiros]]

Attachment: Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/18382

added integration test to confirm that patch for Bug 982240 really fixed this problem and also to avoid regressions.

Comment 8

[Miller Medeiros [:millermedeiros]]

marking it as a duplicate of Bug 982240 since :gaye decided that it would be better if it was done as a single patch (easier to review/revert and they are tightly coupled anyway)