982240 - [Calendar] Day view: disabling calendar hides hours that contained events

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Calendar, defect)

Description

[Miller Medeiros [:millermedeiros]]

Description:
After disabling a calendar, all hours that contained events disappear. - If event was at 9am the 9am "row" will disappear.

Repro Steps:
1) Navigate to Calendar App
2) Create an event for Offline account
3) Navigate to account settings by tapping on icon on top left corner of screen
4) Tap on calendar accounts to uncheck and stop tracking them
5) Return to the calendar and navigate to day view

Actual Result:
Day view doesn't display all hours for the day (hides hour that contained event)

Expected Results:
Day view should display all day hours.

Important notes:
It is the correct behavior for the "month view" tho (both views are coupled).

this is somewhat related to Bug 969472

Comment 1

[Miller Medeiros [:millermedeiros]]

depends on Bug 969472 since I'll reuse the integration tests. They are not exactly the same bug but they are related.

Comment 2

[Miller Medeiros [:millermedeiros]]

Attachment: Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/18091

Comment 3

[Miller Medeiros [:millermedeiros]]

moving it to next sprint since blocker only landed over the weekend and patch was not reviewed yet. I just rebased the PR to reflect latest code on master. :gaye, please feel free to review it.

Comment 7

[Miller Medeiros [:millermedeiros]]

Comment on attachment 8403570 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/18091

Gareth, I updated the patch so now all the changes are in a single commit and marked the other bug as a duplicate (the one that the changes was basically just to the tests). Please review this patch before end of week (we're almost at the end of the sprint). Thanks!

Comment 8

[Gareth Aye [:gaye] (back from PTO)]

Comment on attachment 8403570 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/18091

A couple nits on GH but otherwise this is great. Nice work!

Comment 9

[Miller Medeiros [:millermedeiros]]

landed into master: https://github.com/mozilla-b2g/gaia/commit/d3f5bda02c1f605e4528a8802fe8408602106776

Comment 10

[Edward Chen[:edchen]]

[Environment]
Gaia      f55fc5c507312c7aac51ec9bb73061fd4ed5c5fb
Gecko     https://hg.mozilla.org/mozilla-central/rev/3285e030d9c0
BuildID   20140504160202
Version   32.0a1
ro.build.version.incremental=324
ro.build.date=Thu Dec 19 14:04:55 CST 2013

[Result]
Pass

Comment 11

[Dean R. Gomez (DeanG)]

The 'All Day' label is still not shown when there is an 'All Day' event in a disabled calendar. Would you like me to write up a new bug on the issue?

1.4 Environmental Variables:
Device: Flame 1.4 MOZ
BuildID: 20140512000204
Gaia: 17fb44880e95bc7ae363a609d811bf5a9a067b5b
Gecko: ec24f847e7c0
Version: 30.0
Firmware Version: v10E

Comment 12

[Miller Medeiros [:millermedeiros]]

This was not uplifted to v1.4 branch, it is not considered a blocker (not a regression) and I only fixed it after 1.4 was "feature complete". - This will probably only land on the next release.