Expose a node front in the Selection object in addition to a raw node

RESOLVED FIXED in Firefox 25

Status

()

Firefox
Developer Tools: Inspector
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: dcamp, Assigned: dcamp)

Tracking

unspecified
Firefox 25
x86
Mac OS X
Points:
---
Dependency tree / graph
Bug Flags:
in-testsuite +

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

Comment hidden (empty)
(Assignee)

Comment 1

5 years ago
Created attachment 758237 [details] [diff] [review]
WIP 1
(Assignee)

Updated

5 years ago
Depends on: 881120
No longer depends on: 877300
(Assignee)

Updated

5 years ago
Attachment #758237 - Attachment is obsolete: true
(Assignee)

Updated

5 years ago
Attachment #764484 - Attachment description: WIP 2 → v1
Attachment #764484 - Flags: review?(paul)

Comment 3

5 years ago
Comment on attachment 764484 [details] [diff] [review]
v1

>diff --git a/browser/devtools/fontinspector/font-inspector.js b/browser/devtools/fontinspector/font-inspector.js
>--- a/browser/devtools/fontinspector/font-inspector.js
>+++ b/browser/devtools/fontinspector/font-inspector.js
>@@ -49,16 +49,17 @@ FontInspector.prototype = {
>     }
>   },
> 
>   /**
>    * Selection 'new-node' event handler.
>    */
>   onNewNode: function FI_onNewNode() {
>     if (this.isActive() &&
>+        this.inspector.selection.isLocal() &&
>         this.inspector.selection.isConnected() &&
>         this.inspector.selection.isElementNode() &&
>         this.inspector.selection.reason != "highlighter") {
>       this.undim();
>       this.update();
>     } else {
>       this.dim();
>     }

I'm not sure to understand why you do that here?
Do you check `isLocal` to disable the font inspector in case of remote inspection?
Attachment #764484 - Flags: review?(paul) → review+
(Assignee)

Comment 4

5 years ago
https://hg.mozilla.org/integration/fx-team/rev/b85c683b215f
Assignee: nobody → dcamp
Whiteboard: [fixed-in-fx-team]
https://hg.mozilla.org/mozilla-central/rev/b85c683b215f
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 25
You need to log in before you can comment on or make changes to this bug.