Closed
Bug 881120
Opened 11 years ago
Closed 11 years ago
Allow clients to specify nodes that shouldn't be released
Categories
(DevTools :: Inspector, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
Firefox 24
People
(Reporter: dcamp, Assigned: dcamp)
References
Details
Attachments
(2 files, 1 obsolete file)
27.78 KB,
patch
|
jwalker
:
review+
|
Details | Diff | Splinter Review |
3.42 KB,
patch
|
jwalker
:
review+
paul
:
review+
|
Details | Diff | Splinter Review |
Clients need to be able to specify interest in a remote node, so that it isn't cleaned up during normal cleanup routines.
Specifically, we need this for markup view's Undo feature when deleting, that keeps around a reference to a detached node in case of undo.
Comment 1•11 years ago
|
||
The debugger's threadGrip request does something similar (promote pause-scoped grips to thread-scoped ones). We should probably generalize the concept and harmonize the implementations at some point.
Assignee | ||
Comment 2•11 years ago
|
||
Hopefully this is the last of the tree-fiddling patches.
Attachment #760258 -
Attachment is obsolete: true
Attachment #761282 -
Flags: review?(jwalker)
Updated•11 years ago
|
Attachment #761282 -
Flags: review?(jwalker) → review+
Assignee | ||
Comment 3•11 years ago
|
||
v2 depends on this small patch
Attachment #763190 -
Flags: review?(jwalker)
Assignee | ||
Updated•11 years ago
|
Attachment #763190 -
Flags: review?(paul)
Updated•11 years ago
|
Attachment #763190 -
Flags: review?(jwalker) → review+
Updated•11 years ago
|
Attachment #763190 -
Flags: review?(paul) → review+
Comment 4•11 years ago
|
||
Paul - I think dcamp gave us both reviews because either of us could review this, not because both of us should review it. So I think you can skip this.
Comment 5•11 years ago
|
||
Timing!
Assignee | ||
Comment 6•11 years ago
|
||
Assignee: nobody → dcamp
Whiteboard: [fixed-in-fx-team]
Comment 7•11 years ago
|
||
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 24
Updated•6 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•