877366 - [traceback] Error handler: Could not record Bango success (webpay transaction expired)

Status: RESOLVED WONTFIX

(Marketplace Graveyard :: Payments/Refunds, defect, P2)

Description

[krupa raj[:krupa]]

I hit this traceback in my Firefox OS while making a (carrier billing) purchase using T-mobile SIM from POland. Isaw it only on the first purchase. All other future purchases worked fine.

sentry: http://sentry.dmz.phx1.mozilla.com/addons/marketplace-dev-webpay/group/14404/

Comment 1

[Kumar McMillan [:kumar]]

caused by:

May 29 12:43:51 localhost6.localdomain: [None] w.bango:INFO Bango payment notice for transaction uuid u'webpay:37d26392-7cd8-4ceb-9c8d-b2f27ba146bc' failed: Client Error 400: https://payments-dev.allizom.org/bango/notification/#012Content: {'moz_transaction': ['Transaction expired: webpay:37d26392-7cd8-4ceb-9c8d-b2f27ba146bc']}#012 :/data/www/marketplace-dev.allizom.org-webpay/webpay/webpay/bango/views.py:46

Comment 2

[Andy McKay]

That makes sense if the transaction takes a long time. Solitude has a timeout of 30 mins for a transaction, after that you can't complete it. Perhaps we should up that to something like a few hours. After all if Bango says the transaction is completed, who are we to argue?

Comment 3

[Andy McKay]

It looks like this transaction took over one hour to complete:

    >>> Transaction.objects.filter(uuid='webpay:37d26392-7cd8-4ceb-9c8d-b2f27ba146bc')[0].created
    datetime.datetime(2013, 5, 29, 11, 29, 14)

Interestingly the payment flow sets BILLING_CONFIGURATION_TIME_OUT at 120 seconds:

https://github.com/mozilla/solitude/blob/master/lib/bango/resources/billing.py#L79

So I'm not sure how this would happen. Keir, does this configuration do what I think, cause the billing configuration to timeout after 120 seconds?

Comment 4

[Andy McKay]

Waiting for feedback.

Comment 5

[Keir Kettle]

Sorry missed this - now the BILLING_CONFIGURATION_TIME_OUT is honoured, was disabled due for testing

Comment 6

[Kumar McMillan [:kumar]]

The Bango transaction timeout is now sync with Solitude's timeout, see bug 887053

I think the next thing to do here is to show an explanation to the user in webpay that a transaction has timed out on the success page, right? There is no way to avoid that scenario.

Comment 7

[Kumar McMillan [:kumar]]

I think this is problematic because when a valid Bango transaction arrives at Mozilla's success handler, the user has paid for goods so we should deliver them (not throw an error).

Comment 8

[Andy McKay]

Yes, but hopefully the server event will come through and tell us that the transaction has been completed successfully and we can recover from all this. Making sure that we recover gracefully from this (and other similar scenarios) could be another bug.

Comment 9

[Kumar McMillan [:kumar]]

This kind of transaction timeout protects against certain attacks (see bug 887345) -- when we have a better way to address them we could remove the expiration check here. Until then I think we need to live with the chance of this error happening in production.