Closed Bug 877560 Opened 8 years ago Closed 8 years ago

B2G RIL: support EF_CBMID (Data Download via SMS-CB)

Categories

(Core :: DOM: Device Interfaces, defect)

ARM
Gonk (Firefox OS)
defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla24

People

(Reporter: vicamo, Assigned: vicamo)

References

Details

Attachments

(2 files, 1 obsolete file)

Gecko reads CBMI & CBMIR since bug 778093 and CBMID is necessary for receiving Class-2 CB messages.

See 3GPP TS 31.102 section 5.4.3 "Data Download via SMS-CB" for USIM and 3GPP TS 51.011 section 11.6.11 "Data Download via SMS-CB" for SIM.
OS: Linux → Gonk (Firefox OS)
Hardware: x86_64 → ARM
Blocks: 877751
No longer blocks: 877751
Attached patch patch (obsolete) — Splinter Review
Assignee: nobody → vyang
Add default CBMIR entries.
Handled internally by modem and part of Qualcomm's release.
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → INVALID
(In reply to Michael Schwartz [:m4] from comment #3)
> Handled internally by modem and part of Qualcomm's release.

Please note Qualcomm's RIL is not the only RIL implementation on B2G.  Close only your own bug!
Status: RESOLVED → REOPENED
Resolution: INVALID → ---
Comment on attachment 756653 [details] [diff] [review]
patch

With PR for external/qemu, we should see following lines in logcat:

  CBMID: [49153,49154,61441,61442]
  Cell Broadcast search lists: {"MMI":null,"CBMI":[45056,45057,61440,61441],"CBMID":[49153,49154,61441,61442],"CBMIR":[45058,49153,     61442,65281]}
  Cell Broadcast search lists(merged): [45056,45057,45058,49154,61440,65281]
Attachment #756653 - Attachment description: Part 1: WIP → patch
Attachment #756653 - Flags: review?(allstars.chh)
Attachment #756670 - Flags: review?(allstars.chh)
Comment on attachment 756653 [details] [diff] [review]
patch

Review of attachment 756653 [details] [diff] [review]:
-----------------------------------------------------------------

Mostly looks good, except for the 'which' pamameter, which I think is redudant.

::: dom/system/gonk/ril_worker.js
@@ +4146,5 @@
>     * Merge all members of cellBroadcastConfigs into mergedCellBroadcastConfig.
>     */
>    _mergeAllCellBroadcastConfigs: function _mergeAllCellBroadcastConfigs() {
>      if (!("CBMI" in this.cellBroadcastConfigs)
> +        || !("CBMID" in this.cellBroadcastConfigs)

The position of '||' seems better if we move to the end of line.

@@ +10742,5 @@
>      ICCIOHelper.loadTransparentEF({fileId: ICC_EF_SPDI,
>                                     callback: callback.bind(this)});
>    },
>  
> +  _readCbmiHelper: function _readCbmiHelper(fileId, which) {

'which' sounds unnecessary to me,
you should do the mapping(fileId -> name) inside this function
Attachment #756653 - Flags: review?(allstars.chh)
Blocks: 879630
Attached patch patch v2Splinter Review
Address previous review comment.
Attachment #756653 - Attachment is obsolete: true
Attachment #758387 - Flags: review?(allstars.chh)
Blocks: 874805
https://hg.mozilla.org/mozilla-central/rev/b61efdb1d7b8
Status: REOPENED → RESOLVED
Closed: 8 years ago8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla24
You need to log in before you can comment on or make changes to this bug.