Closed
Bug 877562
Opened 11 years ago
Closed 11 years ago
Intermittent test_identicalManifest.html| application crashed [@ PL_DHashTableOperate] after "Assertion failure: op == PL_DHASH_LOOKUP || (*(uint32_t*)(table->entryStore + ((uint32_t)1 << (32 - (table)->hashShift)) * table->entrySize)) == 0"
Categories
(Core :: Preferences: Backend, defect)
Tracking
()
RESOLVED
FIXED
mozilla26
People
(Reporter: jesup, Assigned: mayhemer)
References
Details
(Keywords: assertion, crash, intermittent-failure)
Crash Data
Attachments
(1 file)
9.24 KB,
patch
|
jduell.mcbugs
:
review+
bajaj
:
approval-mozilla-aurora+
bajaj
:
approval-mozilla-beta+
mayhemer
:
checkin+
|
Details | Diff | Splinter Review |
+++ This bug was initially created as a clone of Bug #864705 +++ +++ This bug was initially created as a clone of Bug #859744 +++ +++ This bug was initially created as a clone of Bug #859414 +++ Out of room in summary. https://tbpl.mozilla.org/php/getParsedLog.php?id=23554109&tree=Mozilla-Beta&full=1 16:13:10 INFO - Assertion failure: op == PL_DHASH_LOOKUP || (*(uint32_t*)(table->entryStore + ((uint32_t)1 << (32 - (table)->hashShift)) * table->entrySize)) == 0, at e:/builds/moz2_slave/m-beta-w32-d-00000000000000000/build/obj-firefox/xpcom/build/pldhash.cpp:573 16:13:13 WARNING - TEST-UNEXPECTED-FAIL | /tests/dom/tests/mochitest/ajax/offline/test_identicalManifest.html | Exited with code -2147483645 during test run
Comment hidden (Legacy TBPL/Treeherder Robot) |
Assignee | ||
Comment 2•11 years ago
|
||
The hash table is accessed on multiple thread w/o a mutex. I'll fix it.
Assignee: nobody → honzab.moz
Status: NEW → ASSIGNED
Comment hidden (Legacy TBPL/Treeherder Robot) |
Assignee | ||
Comment 4•11 years ago
|
||
https://tbpl.mozilla.org/?tree=Try&rev=60e80338b519
Assignee | ||
Comment 5•11 years ago
|
||
Try is green, I think we have a fix.
Attachment #790157 -
Flags: review?(jduell.mcbugs)
Updated•11 years ago
|
Attachment #790157 -
Flags: review?(jduell.mcbugs) → review+
Assignee | ||
Comment 6•11 years ago
|
||
Comment on attachment 790157 [details] [diff] [review] v1 https://hg.mozilla.org/integration/mozilla-inbound/rev/067bc81b7074
Attachment #790157 -
Flags: checkin+
Comment 7•11 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/067bc81b7074
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Target Milestone: --- → mozilla26
Comment 8•11 years ago
|
||
Can you please request approval for uplift to aurora/beta?
status-firefox24:
--- → affected
status-firefox25:
--- → affected
status-firefox26:
--- → fixed
Flags: needinfo?(honzab.moz)
Assignee | ||
Comment 9•11 years ago
|
||
Comment on attachment 790157 [details] [diff] [review] v1 [Approval Request Comment] Bug caused by (feature/regressing bug #): since ever User impact if declined: concurrent thread memory access (hashtable operations) causing heap corruption leading to unpredictable crashes Testing completed (on m-c, etc.): just landed on m-c Risk to taking this patch (and alternatives if risky): this adds a new lock, I took care not to call foreign code under it, still it's a new lock that might introduce a deadlock (however, IMO low probability of it) String or IDL/UUID changes made by this patch: none
Attachment #790157 -
Flags: approval-mozilla-beta?
Attachment #790157 -
Flags: approval-mozilla-aurora?
Assignee | ||
Comment 10•11 years ago
|
||
(In reply to Ryan VanderMeulen [:RyanVM UTC-4] from comment #8) > Can you please request approval for uplift to aurora/beta? Done
Flags: needinfo?(honzab.moz)
Updated•11 years ago
|
Attachment #790157 -
Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Comment 11•11 years ago
|
||
(In reply to Honza Bambas (:mayhemer) from comment #9) > Comment on attachment 790157 [details] [diff] [review] > v1 > > [Approval Request Comment] > Bug caused by (feature/regressing bug #): since ever > User impact if declined: concurrent thread memory access (hashtable > operations) causing heap corruption leading to unpredictable crashes > Testing completed (on m-c, etc.): just landed on m-c > Risk to taking this patch (and alternatives if risky): this adds a new lock, > I took care not to call foreign code under it, still it's a new lock that > might introduce a deadlock (however, IMO low probability of it) Given the risk here I'll let it bake on nightly/aurora a couple of days in preparation for a beta uplift. > String or IDL/UUID changes made by this patch: none
Updated•11 years ago
|
Attachment #790157 -
Flags: approval-mozilla-beta? → approval-mozilla-beta+
You need to log in
before you can comment on or make changes to this bug.
Description
•