877609 - Port GTK2 to GTK3 - widget padding

Status: RESOLVED FIXED

(Core :: Widget: Gtk, defect)

Description

[Martin Stránský [:stransky] (ni? me)]

+++ This bug was initially created as a clone of Bug #627699 +++

GTK+ 3.0 and GNOME 3 are approaching and we should get Firefox ready for them. This bug is for correct widget padding, see:

https://bugzilla.mozilla.org/show_bug.cgi?id=627699#c251
https://bugzilla.mozilla.org/show_bug.cgi?id=627699#c262
https://bug627699.bugzilla.mozilla.org/attachment.cgi?id=727638

Comment 1

[Martin Stránský [:stransky] (ni? me)]

Attachment: part1

First part of the padding patch, reflects comments from https://bugzilla.mozilla.org/show_bug.cgi?id=627699#c262

Comment 2

[Karl Tomlinson (:karlt)]

Comment on attachment 755892 [details] [diff] [review]
part1

>   gtk_style_context_add_class(style, GTK_STYLE_CLASS_SCALE);
>-  gtk_style_context_get_border(style, state_flags, &border);
> 
>   if (flags == GTK_ORIENTATION_HORIZONTAL) {
>-    x = border.left;
>+    x = gtk_widget_get_margin_left(widget);
>     y++;
>   }
>   else {
>     x++;
>-    y = border.top;
>+    y = gtk_widget_get_margin_top(widget);
>   }

It seems there is a margin on the GtkWidget and a margin on the
GtkStyleContext.  gtk_range_draw uses the margin from the style context and I
can't see that the margin on the widget is related, so I think this code
should also use the margin from the style context.

Comment 3

[Martin Stránský [:stransky] (ni? me)]

Attachment: part1 v.2

Fixed the part1

Comment 4

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/9fc02d074c69

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/9fc02d074c69

Comment 6

[Martin Stránský [:stransky] (ni? me)]

Padding in GtkTree is addressed in Bug 897404 and I don't see any other bugs.