877820 - WebAudio div-by-zero [@mozilla::RoundUpToAudioBlock]

Status: RESOLVED FIXED

(Core :: Web Audio, defect)

Description

[Christoph Diehl [:posidron]]

Attachment: testcase

content/media/MediaStreamGraph.cpp:1027

    GraphTime endBlockingDecisions =
*     RoundUpToAudioBlock(sampleRate, mCurrentTime + MillisecondsToMediaTime(AUDIO_TARGET_MS));


content/media/MediaStreamGraph.cpp:952

static GraphTime
RoundUpToAudioBlock(TrackRate aSampleRate, GraphTime aTime)
{
[...]
  return
    ((((blocksAtIdealaSampleRate + 1)*WEBAUDIO_BLOCK_SIZE) << MEDIA_TIME_FRAC_BITS)
     + aSampleRate - 1)/aSampleRate;
}


Tested with http://hg.mozilla.org/integration/mozilla-inbound/rev/d7c6d6061ab5

Comment 1

[(no longer active)]

Boring stuff!  We truncate the float sampling rate to an integer, so we need to check against 1.0 not 0.0!

Comment 2

[(no longer active)]

Attachment: Patch (v1)

Comment 3

[(no longer active)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/2ac5f1aa16a5

Comment 4

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/2ac5f1aa16a5

Comment 5

[(no longer active)]

Mass moving Web Audio bugs to the Web Audio component.  Filter on duckityduck.