Closed
Bug 877985
Opened 11 years ago
Closed 11 years ago
expose node_parent_of relation via accNavigate
Categories
(Core :: Disability Access APIs, defect)
Core
Disability Access APIs
Tracking
()
RESOLVED
FIXED
mozilla24
People
(Reporter: surkov, Assigned: marcosadp)
References
(Blocks 1 open bug)
Details
(Keywords: access, Whiteboard: [good first bug][mentor=surkov.alexander@gmail.com][lang=c++])
Attachments
(1 file, 1 obsolete file)
1.77 KB,
patch
|
surkov
:
review+
|
Details | Diff | Splinter Review |
IA2 node_parent_of relation was implemented in bug 873453. It should be exposed via AccessibleWrap::accNavigate. You should add a constant into windows/msaa/AccessibleWrap.h and fix it AccessibleWrap.cpp.
Assignee | ||
Comment 1•11 years ago
|
||
Could you please assign this bug to me? I will be submitting a patch shortly.
Updated•11 years ago
|
Assignee: nobody → marcosadp
Assignee | ||
Comment 2•11 years ago
|
||
Adds NAVRELATION_NODE_PARENT_OF to accessible/src/windows/msaa/AccessibleWrap.h and exposes it via AccessibleWrap::accNavigate (accessible/src/windows/msaa/AccessibleWrap.cpp)
Attachment #756704 -
Flags: review?(surkov.alexander)
Reporter | ||
Comment 3•11 years ago
|
||
Comment on attachment 756704 [details] [diff] [review] patch Review of attachment 756704 [details] [diff] [review]: ----------------------------------------------------------------- ::: accessible/src/windows/msaa/AccessibleWrap.cpp @@ +890,5 @@ > xpRelation = nsIAccessibleRelation::RELATION_NODE_CHILD_OF; > break; > + case NAVRELATION_NODE_PARENT_OF: > + xpRelation = nsIAccessibleRelation::RELATION_NODE_PARENT_OF; > + break; please put it in the order defined by enum
Attachment #756704 -
Flags: review?(surkov.alexander) → review+
Assignee | ||
Comment 4•11 years ago
|
||
Should now be in the same order as defined by enum.
Attachment #756704 -
Attachment is obsolete: true
Attachment #757167 -
Flags: review?(surkov.alexander)
Hi I am interested in working on this bug,but it's my first time to work on with debug,can anybody guide me on how to get started with it?Thanks a lot.
Reporter | ||
Comment 6•11 years ago
|
||
Comment on attachment 757167 [details] [diff] [review] patch v2 Review of attachment 757167 [details] [diff] [review]: ----------------------------------------------------------------- thanks, r=me
Attachment #757167 -
Flags: review?(surkov.alexander) → review+
Reporter | ||
Updated•11 years ago
|
Keywords: checkin-needed
Reporter | ||
Comment 7•11 years ago
|
||
(In reply to MikeLing from comment #5) > Hi I am interested in working on this bug,but it's my first time to work on > with debug,can anybody guide me on how to get started with it?Thanks a lot. This is assigned bug so you need to find another one. I saw you commented the same into dozen of bugs mentored by me. You'd need to choose one for the start. In general each bug has steps how to fix it. Feel free to ask questions if certain step is not clear.
Assignee | ||
Comment 8•11 years ago
|
||
You're welcome. By the way, does this bug require any further action on my part or are we good?
Reporter | ||
Comment 9•11 years ago
|
||
(In reply to Marcos A. Di Pietro from comment #8) > You're welcome. By the way, does this bug require any further action on my > part or are we good? yeah, we are good, I added checking-needed keyword so it will be landed in day or two. If you will then you can pick up another bug: https://bugzilla.mozilla.org/buglist.cgi?list_id=6705162&resolution=---&query_based_on=mentored&status_whiteboard_type=substring&query_format=advanced&status_whiteboard=[mentor%3D&component=Disability%20Access%20APIs&product=Core&known_name=mentored
Comment 10•11 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/c07231373d6b
Keywords: checkin-needed
Comment 11•11 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/c07231373d6b
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla24
You need to log in
before you can comment on or make changes to this bug.
Description
•