Last Comment Bug 877985 - expose node_parent_of relation via accNavigate
: expose node_parent_of relation via accNavigate
Status: RESOLVED FIXED
[good first bug][mentor=surkov.alexan...
: access
Product: Core
Classification: Components
Component: Disability Access APIs (show other bugs)
: unspecified
: All All
: -- normal (vote)
: mozilla24
Assigned To: Marcos A. Di Pietro
:
Mentors:
Depends on:
Blocks: ia2
  Show dependency treegraph
 
Reported: 2013-05-31 00:43 PDT by alexander :surkov
Modified: 2013-06-03 13:05 PDT (History)
2 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
patch (1.97 KB, patch)
2013-05-31 11:37 PDT, Marcos A. Di Pietro
surkov.alexander: review+
Details | Diff | Review
patch v2 (1.77 KB, patch)
2013-06-02 13:17 PDT, Marcos A. Di Pietro
surkov.alexander: review+
Details | Diff | Review

Description alexander :surkov 2013-05-31 00:43:44 PDT
IA2 node_parent_of relation was implemented in bug 873453. It should be exposed via AccessibleWrap::accNavigate. You should add a constant into windows/msaa/AccessibleWrap.h and fix it AccessibleWrap.cpp.
Comment 1 Marcos A. Di Pietro 2013-05-31 11:33:29 PDT
Could you please assign this bug to me? I will be submitting a patch shortly.
Comment 2 Marcos A. Di Pietro 2013-05-31 11:37:44 PDT
Created attachment 756704 [details] [diff] [review]
patch

Adds NAVRELATION_NODE_PARENT_OF to accessible/src/windows/msaa/AccessibleWrap.h
and exposes it via AccessibleWrap::accNavigate (accessible/src/windows/msaa/AccessibleWrap.cpp)
Comment 3 alexander :surkov 2013-06-01 21:22:58 PDT
Comment on attachment 756704 [details] [diff] [review]
patch

Review of attachment 756704 [details] [diff] [review]:
-----------------------------------------------------------------

::: accessible/src/windows/msaa/AccessibleWrap.cpp
@@ +890,5 @@
>        xpRelation = nsIAccessibleRelation::RELATION_NODE_CHILD_OF;
>        break;
> +    case NAVRELATION_NODE_PARENT_OF:
> +      xpRelation = nsIAccessibleRelation::RELATION_NODE_PARENT_OF;
> +      break;

please put it in the order defined by enum
Comment 4 Marcos A. Di Pietro 2013-06-02 13:17:44 PDT
Created attachment 757167 [details] [diff] [review]
patch v2

Should now be in the same order as defined by enum.
Comment 5 MikeLing 2013-06-02 16:19:08 PDT
Hi I am interested in working on this bug,but it's my first time to work on with debug,can anybody guide me on how to get started with it?Thanks a lot.
Comment 6 alexander :surkov 2013-06-02 19:54:34 PDT
Comment on attachment 757167 [details] [diff] [review]
patch v2

Review of attachment 757167 [details] [diff] [review]:
-----------------------------------------------------------------

thanks, r=me
Comment 7 alexander :surkov 2013-06-02 19:58:29 PDT
(In reply to MikeLing from comment #5)
> Hi I am interested in working on this bug,but it's my first time to work on
> with debug,can anybody guide me on how to get started with it?Thanks a lot.

This is assigned bug so you need to find another one. I saw you commented the same into dozen of bugs mentored by me. You'd need to choose one for the start. In general each bug has steps how to fix it. Feel free to ask questions if certain step is not clear.
Comment 8 Marcos A. Di Pietro 2013-06-02 20:23:43 PDT
You're welcome. By the way, does this bug require any further action on my part or are we good?
Comment 9 alexander :surkov 2013-06-02 20:36:40 PDT
(In reply to Marcos A. Di Pietro from comment #8)
> You're welcome. By the way, does this bug require any further action on my
> part or are we good?

yeah, we are good, I added checking-needed keyword so it will be landed in day or two. If you will then you can pick up another bug: https://bugzilla.mozilla.org/buglist.cgi?list_id=6705162&resolution=---&query_based_on=mentored&status_whiteboard_type=substring&query_format=advanced&status_whiteboard=[mentor%3D&component=Disability%20Access%20APIs&product=Core&known_name=mentored
Comment 10 Ryan VanderMeulen [:RyanVM] 2013-06-03 05:51:08 PDT
https://hg.mozilla.org/integration/mozilla-inbound/rev/c07231373d6b
Comment 11 Ryan VanderMeulen [:RyanVM] 2013-06-03 13:05:25 PDT
https://hg.mozilla.org/mozilla-central/rev/c07231373d6b

Note You need to log in before you can comment on or make changes to this bug.