Closed Bug 877985 Opened 7 years ago Closed 7 years ago

expose node_parent_of relation via accNavigate

Categories

(Core :: Disability Access APIs, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla24

People

(Reporter: surkov, Assigned: marcosadp)

References

(Blocks 1 open bug)

Details

(Keywords: access, Whiteboard: [good first bug][mentor=surkov.alexander@gmail.com][lang=c++])

Attachments

(1 file, 1 obsolete file)

IA2 node_parent_of relation was implemented in bug 873453. It should be exposed via AccessibleWrap::accNavigate. You should add a constant into windows/msaa/AccessibleWrap.h and fix it AccessibleWrap.cpp.
Could you please assign this bug to me? I will be submitting a patch shortly.
Assignee: nobody → marcosadp
Attached patch patch (obsolete) — Splinter Review
Adds NAVRELATION_NODE_PARENT_OF to accessible/src/windows/msaa/AccessibleWrap.h
and exposes it via AccessibleWrap::accNavigate (accessible/src/windows/msaa/AccessibleWrap.cpp)
Attachment #756704 - Flags: review?(surkov.alexander)
Comment on attachment 756704 [details] [diff] [review]
patch

Review of attachment 756704 [details] [diff] [review]:
-----------------------------------------------------------------

::: accessible/src/windows/msaa/AccessibleWrap.cpp
@@ +890,5 @@
>        xpRelation = nsIAccessibleRelation::RELATION_NODE_CHILD_OF;
>        break;
> +    case NAVRELATION_NODE_PARENT_OF:
> +      xpRelation = nsIAccessibleRelation::RELATION_NODE_PARENT_OF;
> +      break;

please put it in the order defined by enum
Attachment #756704 - Flags: review?(surkov.alexander) → review+
Attached patch patch v2Splinter Review
Should now be in the same order as defined by enum.
Attachment #756704 - Attachment is obsolete: true
Attachment #757167 - Flags: review?(surkov.alexander)
Hi I am interested in working on this bug,but it's my first time to work on with debug,can anybody guide me on how to get started with it?Thanks a lot.
Comment on attachment 757167 [details] [diff] [review]
patch v2

Review of attachment 757167 [details] [diff] [review]:
-----------------------------------------------------------------

thanks, r=me
Attachment #757167 - Flags: review?(surkov.alexander) → review+
Keywords: checkin-needed
(In reply to MikeLing from comment #5)
> Hi I am interested in working on this bug,but it's my first time to work on
> with debug,can anybody guide me on how to get started with it?Thanks a lot.

This is assigned bug so you need to find another one. I saw you commented the same into dozen of bugs mentored by me. You'd need to choose one for the start. In general each bug has steps how to fix it. Feel free to ask questions if certain step is not clear.
You're welcome. By the way, does this bug require any further action on my part or are we good?
(In reply to Marcos A. Di Pietro from comment #8)
> You're welcome. By the way, does this bug require any further action on my
> part or are we good?

yeah, we are good, I added checking-needed keyword so it will be landed in day or two. If you will then you can pick up another bug: https://bugzilla.mozilla.org/buglist.cgi?list_id=6705162&resolution=---&query_based_on=mentored&status_whiteboard_type=substring&query_format=advanced&status_whiteboard=[mentor%3D&component=Disability%20Access%20APIs&product=Core&known_name=mentored
https://hg.mozilla.org/mozilla-central/rev/c07231373d6b
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla24
You need to log in before you can comment on or make changes to this bug.