878329 - Bring back banner for incompatible browsers

Status: RESOLVED FIXED

(Marketplace Graveyard :: Consumer Pages, defect, P4)

Description

[Christopher Van Wiemeersch [:cvan]]

If your version of Firefox is too old or if your browser doesn't support apps, we used to show this cute little banner:

http://f.cl.ly/items/0J122Q2z102s1H251r0b/Screen%20Shot%202013-05-31%20at%204.13.41%20PM.png

Let's bring that bad boy back!

Comment 1

[Maria Sandberg [:mushi]]

:) I think we need a visual remake of it to match the lighter theme, yah? 
Adding Michael.

Comment 2

[Michael Maslaney [:mmaslaney] ([e-mail])]

"it's been broughten"

Comment 3

[Michael Maslaney [:mmaslaney] ([e-mail])]

Attachment: Updated Browser Prompt – Mobile

Mocks:

https://www.dropbox.com/s/rrg7deafhfvlsu9/Marketplace_Prompts_v2.zip

Comment 4

[Michael Maslaney [:mmaslaney] ([e-mail])]

Attachment: Updated Browser Prompt – Desktop

Comment 5

[Christopher Van Wiemeersch [:cvan]]

Looks cute - but that X is just dangling there all by its wee self!

Comment 6

[Michael Maslaney [:mmaslaney] ([e-mail])]

I think it looks fine, but we could try placing a vertical rule next to it and compare the both.

Comment 7

[Chuck Harmston [:chuck]]

There's a PR up (with screenshots) implementing this here: https://github.com/mozilla/fireplace/pull/295

Tony, thoughts on how it looks?

Comment 8

[Tony Santos [:tsmuse]]

I think it's strangely tall in the wider versions (1023px and wider), but as we currently don't have time to pick up this visual design task right now and I agree notifying users is important, I'm inclined to say it's ok with a "I'd like to loop back on it in the near future when we bring a real desktop design to Marketplace"

Comment 9

[Chuck Harmston [:chuck]]

Thanks!

Landed here: https://github.com/mozilla/fireplace/compare/771e6597...be55aaf34

STR:

When using a device that supports navigator.mozApps (e.g. Firefox desktop, FFOS browser): the banner should never appear.

When using a device that does not support navigator.mozApps:
1) https://marketplace-dev.allizom.org/
2) The banner should be displayed across the top, as in 
     - It should persist across page changes (e.g. changing categories)
     - It should have the visual appearance indicated in mocks and in the screenshots in the pull request linked in comment 7
3) When the "X" button is clicked, it should be dismissed.
     - It should no longer appear on any page loads until localStorage is cleared.

Comment 10

[krupa raj[:krupa]]

I don't see the banner on Chrome or Safari (iPhone)

Comment 11

[krupa raj[:krupa]]

Attachment: screenshot for reopening

Comment 12

[Matt Basta [:basta]]

https://github.com/mozilla/zamboni/commit/1979548861d1e85f3a5cbff6eab5a8cd8abc34f9

DON'T WORRY GUYS I GOT THIS