Closed Bug 879533 Opened 11 years ago Closed 11 years ago

[keyboard] Remove single word suggestion if only one entry shown

Categories

(Firefox OS Graveyard :: Gaia::Keyboard, defect)

x86
macOS
defect
Not set
normal

Tracking

(b2g18 fixed)

RESOLVED FIXED
Tracking Status
b2g18 --- fixed

People

(Reporter: tchung, Unassigned)

References

Details

Attachments

(2 files)

Attached image screenshot
If there is only one entry shown under word suggestion, we should remove it and not show it to the user.  The entry matches the typed word anyway, so its useless.

See screenshot

Repro:
1) install master build on unagi, 6/4/2013
2) enable word suggestions
3) type in one word that is clearly a mistake
4) Verify there is one suggested word that matches what you typed.   This is redundant, because it's suggesting a word you already know.  Doesnt need to be there.

Expected:
- if single word suggestion, hide it from the UI

ActuaL:
- single word suggestion is the same as what the user typed.
Please add a testcase for this bug to moztrap for 1.1 testsuite.  If yes, mark this in-moztrap+ when completed.  If not, mark this in-moztrap-.
Flags: in-moztrap?(cschmoeckel)
Attachment #758877 - Flags: review?(eshapiro)
In addition to fixing the bug described here, this patch removes some unnecessary capitalization code (suggestions are now capitalized by the predition engine, so we don't need to redo that) and also inserts a simple defense against bug 879572, which I could never reproduce.
Attachment #758877 - Flags: review?(eshapiro) → review+
Fixed on master: https://github.com/mozilla-b2g/gaia/commit/eed087331dcdf1a509286ca125c013869a780968
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Uplifted to v1-train in bug 873934
Added Keyboard Suite Test Case #8494 - [Keyboard] Word Suggestion bar is empty when only one entry is available
Flags: in-moztrap?(cschmoeckel) → in-moztrap+
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: