878441 - Add simple mutation watching to the inspector actor

Status: RESOLVED FIXED

(DevTools :: Inspector, defect)

Description

[Dave Camp (:dcamp)]

For mutations that don't change the tree, like attributes and text values.

Comment 1

[Dave Camp (:dcamp)]

Attachment: v1

Comment 2

[Joe Walker [:jwalker]]

Comment on attachment 757031 [details] [diff] [review]
v1

Review of attachment 757031 [details] [diff] [review]:
-----------------------------------------------------------------

I'd like to take another pass when there are docs to make sure I get it properly.

::: toolkit/devtools/server/actors/inspector.js
@@ +224,4 @@
>  
>      if (form.parent) {
>        // Get the owner actor for this actor (the walker), and find the
>        // parent node of this actor from it, creating a standin node if

Nit: stand-in? Avoids people going 'standing? what's a standing node?'

@@ +230,5 @@
>        this.reparent(parentNodeFront);
>      }
>    },
>  
> +  updateMutation: function(change) {

I think we need docs here.

@@ +1007,5 @@
> +      mutations: RetVal("array:dommutation")
> +    }
> +  }),
> +
> +  onMutations: function(mutations) {

docs?

Comment 3

[Dave Camp (:dcamp)]

Attachment: v2

Now with better docs.

Comment 4

[Dave Camp (:dcamp)]

Attachment: v3

Add in some bugfixes that were in the next patch on my queue.

Comment 5

[Joe Walker [:jwalker]]

Comment on attachment 759396 [details] [diff] [review]
v3

Review of attachment 759396 [details] [diff] [review]:
-----------------------------------------------------------------

::: toolkit/devtools/server/actors/inspector.js
@@ +226,5 @@
>    form: function(form, detail, ctx) {
>      // Shallow copy of the form.  We could just store a reference, but
>      // eventually we'll want to update some of the data.
>      this._form = object.merge(form);
> +    this._form.attrs = this._form.attrs ? this._form.attrs.slice() : [];

How confident are you that there are no falsey arrays?
I don't think there are any, but I don't know the depths of wtfjs.

Comment 6

[Dave Camp (:dcamp)]

From dherman's Effective JavaScript,

"There are exactly seven falsy values: false, 0, -0, "", NaN, null, and undefined.  All other values are truthy."

An empty array might still == null, but we're good on truthiness.

Comment 7

[Dave Camp (:dcamp)]

https://hg.mozilla.org/integration/fx-team/rev/f9b59a3ef675

Comment 8

[Tim Taubert [:ttaubert] (inactive)]

https://hg.mozilla.org/mozilla-central/rev/f9b59a3ef675