878442 - Add tree change mutations to the inspector actor

Status: RESOLVED FIXED

(DevTools :: Inspector, defect)

Comment 1

[Dave Camp (:dcamp)]

Attachment: WIP 1

This is untested, but I think it should work.  Doesn't yet fake child list mutations for iframe loads, I'll probably save that for a followup.

Comment 2

[Dave Camp (:dcamp)]

Attachment: v1

With tests and the fixes needed to make those tests work.

Comment 3

[Dave Camp (:dcamp)]

(oops, the child list changes will need to include numChildren updates for the nodes...)

Comment 4

[Dave Camp (:dcamp)]

Attachment: v2

This version updates numChildren

Comment 5

[Dave Camp (:dcamp)]

Attachment: v3

Improved documentation.

Comment 6

[Joe Walker [:jwalker]]

Comment on attachment 759495 [details] [diff] [review]
v3

Review of attachment 759495 [details] [diff] [review]:
-----------------------------------------------------------------

::: toolkit/devtools/server/actors/inspector.js
@@ +1051,5 @@
> +   *   removed: array of <domnode actor ID> The list of actors *previously
> +   *     seen by the client* that were removed from the target node.
> +   *
> +   * Actors that are included in a MutationRecord's `removed` but
> +   * not in an `added` has been removed from the client's ownership

s/has been removed/have been removed/

@@ +1105,5 @@
>            mutation.incompleteValue = true;
>          } else {
>            mutation.newValue = targetNode.nodeValue;
>          }
> +      } else if (mutation.type === "childList") {

This is kind of a prove-i've-been-here comment. Wouldn't 'mutation' be a better name:

    for (let mutation of mutations) ....

Ignore at will.

Comment 7

[Dave Camp (:dcamp)]

I used 'change' instead of 'mutation' because it seemed to small a change from 'mutations' by total percentage of characters.  But I kinda regret that now.

Enough patches would bitrot if I changed that now that I'd prefer a followup if we care enough.

Comment 8

[Dave Camp (:dcamp)]

(In reply to Dave Camp (:dcamp) from comment #7)
> I used 'change' instead of 'mutation' because it seemed to small a change
> from 'mutations' by total percentage of characters.

Boy did I mess that sentence up.

"mutation" vs "mutations" seemed harder to see the difference between than "change" vs. "mutations".  But I regret that, I think.

Comment 9

[Dave Camp (:dcamp)]

https://hg.mozilla.org/integration/fx-team/rev/cccfd3161714

Comment 10

[Tim Taubert [:ttaubert] (inactive)]

https://hg.mozilla.org/mozilla-central/rev/cccfd3161714