Closed Bug 878721 Opened 11 years ago Closed 11 years ago

Taps do not work after closing the find in page interface on mobile pages on the Samsung Galaxy S2

Categories

(Firefox for Android Graveyard :: Toolbar, defect)

Product:
Firefox for Android Graveyard
Component:
Toolbar
Version:
24 Branch
Platform:
ARM
Android
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(firefox22 unaffected, firefox23 unaffected, firefox24 affected, fennec24+)

Status:
RESOLVED WORKSFORME
Tracking Flags:
Tracking Status
firefox22 --- unaffected
firefox23 --- unaffected
firefox24 --- affected
fennec 24+ ---

People

(Reporter: AdrianT, Unassigned)

References

Details

(Keywords: regression)

Attachments

(1 file)

logs
3.66 MB, text/plain
Details
Attached file logs —
Nighlty 24.0a1 2013-06-02 Samsung Galaxy S2 (Android 4.0.4) Steps to reproduce: 1) Open any mobile website (for e.g. search Mozilla using the wikipedia search engine) 2) Open Find in Page and search for part of a word that is in view but is not a link (for e.g. "Moz" for the page title) 3) Close the Find in Page UI by tapping the "x" button and tap any link on the page without scrolling it. Expected results: The link is loaded Actual result: Any tap until the page is scrolled will default to the find in page selection Note: This is not reproducible on other devices then the Galaxy S2 This may be related/have the same root cause as bug 876689 This is not reproducible on Aurora or Beta and since bug 876689 is reproducible I can't change the option for the dynamic toolbar in about:config
Summary: Taps do not work after removing the find in page interface on the Samsung Galaxy S2 → Taps do not work after closing the find in page interface on mobile pages on the Samsung Galaxy S2
I'm not able to reproduce this at all on my S2 (Android 4.1) using your steps. Any errors in console when you tap a link? Are you sure you're not just seeing bug 876060?
I don't think it's the same as bug 876060. Here is a video capture: http://youtu.be/W4KOOKnkHUY. You can see that in this case the taps are registered on the page's menu/navigation button(upper left corner of the screen) In the attached logs there are a lot of NullPoint exceptions generated by the taps: 01-01 03:05:50.025 E/GeckoTouchEventHandler( 4577): Unexpected empty event queue in processEventBlock! 01-01 03:05:50.025 E/GeckoTouchEventHandler( 4577): java.lang.Exception 01-01 03:05:50.025 E/GeckoTouchEventHandler( 4577): at org.mozilla.gecko.gfx.TouchEventHandler.processEventBlock(TouchEventHandler.java:251) 01-01 03:05:50.025 E/GeckoTouchEventHandler( 4577): at org.mozilla.gecko.gfx.TouchEventHandler.handleEventListenerAction(TouchEventHandler.java:204) 01-01 03:05:50.025 E/GeckoTouchEventHandler( 4577): at org.mozilla.gecko.gfx.JavaPanZoomController.notifyDefaultActionPrevented(JavaPanZoomController.java:331) 01-01 03:05:50.025 E/GeckoTouchEventHandler( 4577): at org.mozilla.gecko.GeckoAppShell$10.run(GeckoAppShell.java:1470) 01-01 03:05:50.025 E/GeckoTouchEventHandler( 4577): at android.os.Handler.handleCallback(Handler.java:605) 01-01 03:05:50.025 E/GeckoTouchEventHandler( 4577): at android.os.Handler.dispatchMessage(Handler.java:92) 01-01 03:05:50.025 E/GeckoTouchEventHandler( 4577): at android.os.Looper.loop(Looper.java:137) 01-01 03:05:50.025 E/GeckoTouchEventHandler( 4577): at android.app.ActivityThread.main(ActivityThread.java:4507) 01-01 03:05:50.025 E/GeckoTouchEventHandler( 4577): at java.lang.reflect.Method.invokeNative(Native Method) 01-01 03:05:50.025 E/GeckoTouchEventHandler( 4577): at java.lang.reflect.Method.invoke(Method.java:511) 01-01 03:05:50.025 E/GeckoTouchEventHandler( 4577): at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:790) 01-01 03:05:50.025 E/GeckoTouchEventHandler( 4577): at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:557) 01-01 03:05:50.025 E/GeckoTouchEventHandler( 4577): at dalvik.system.NativeStart.main(Native Method) 01-01 03:05:50.050 E/GeckoEvent( 4577): Error creating motion point 0 01-01 03:05:50.050 E/GeckoEvent( 4577): java.lang.NullPointerException 01-01 03:05:50.050 E/GeckoEvent( 4577): at org.mozilla.gecko.GeckoEvent.addMotionPoint(GeckoEvent.java:390) 01-01 03:05:50.050 E/GeckoEvent( 4577): at org.mozilla.gecko.GeckoEvent.initMotionEvent(GeckoEvent.java:367) 01-01 03:05:50.050 E/GeckoEvent( 4577): at org.mozilla.gecko.GeckoEvent.createMotionEvent(GeckoEvent.java:340) 01-01 03:05:50.050 E/GeckoEvent( 4577): at org.mozilla.gecko.gfx.LayerView$1.onTouch(LayerView.java:154) 01-01 03:05:50.050 E/GeckoEvent( 4577): at org.mozilla.gecko.gfx.LayerView.runTouchInterceptors(LayerView.java:201) 01-01 03:05:50.050 E/GeckoEvent( 4577): at org.mozilla.gecko.gfx.LayerView.onTouchEvent(LayerView.java:222) 01-01 03:05:50.050 E/GeckoEvent( 4577): at android.view.View.dispatchTouchEvent(View.java:5696) 01-01 03:05:50.050 E/GeckoEvent( 4577): at android.view.ViewGroup.dispatchTransformedTouchEvent(ViewGroup.java:1951) 01-01 03:05:50.050 E/GeckoEvent( 4577): at android.view.ViewGroup.dispatchTouchEvent(ViewGroup.java:1712) 01-01 03:05:50.050 E/GeckoEvent( 4577): at android.view.ViewGroup.dispatchTransformedTouchEvent(ViewGroup.java:1957) 01-01 03:05:50.050 E/GeckoEvent( 4577): at android.view.ViewGroup.dispatchTouchEvent(ViewGroup.java:1726) 01-01 03:05:50.050 E/GeckoEvent( 4577): at android.view.ViewGroup.dispatchTransformedTouchEvent(ViewGroup.java:1957) 01-01 03:05:50.050 E/GeckoEvent( 4577): at android.view.ViewGroup.dispatchTouchEvent(ViewGroup.java:1726) 01-01 03:05:50.050 E/GeckoEvent( 4577): at android.view.ViewGroup.dispatchTransformedTouchEvent(ViewGroup.java:1957) 01-01 03:05:50.050 E/GeckoEvent( 4577): at android.view.ViewGroup.dispatchTouchEvent(ViewGroup.java:1726) 01-01 03:05:50.050 E/GeckoEvent( 4577): at android.view.ViewGroup.dispatchTransformedTouchEvent(ViewGroup.java:1957) 01-01 03:05:50.050 E/GeckoEvent( 4577): at android.view.ViewGroup.dispatchTouchEvent(ViewGroup.java:1726) 01-01 03:05:50.050 E/GeckoEvent( 4577): at android.view.ViewGroup.dispatchTransformedTouchEvent(ViewGroup.java:1957) 01-01 03:05:50.050 E/GeckoEvent( 4577): at android.view.ViewGroup.dispatchTouchEvent(ViewGroup.java:1726) 01-01 03:05:50.050 E/GeckoEvent( 4577): at android.view.ViewGroup.dispatchTransformedTouchEvent(ViewGroup.java:1957) 01-01 03:05:50.050 E/GeckoEvent( 4577): at android.view.ViewGroup.dispatchTouchEvent(ViewGroup.java:1726) 01-01 03:05:50.050 E/GeckoEvent( 4577): at com.android.internal.policy.impl.PhoneWindow$DecorView.superDispatchTouchEvent(PhoneWindow.java:2063) 01-01 03:05:50.050 E/GeckoEvent( 4577): at com.android.internal.policy.impl.PhoneWindow.superDispatchTouchEvent(PhoneWindow.java:1399) 01-01 03:05:50.050 E/GeckoEvent( 4577): at android.app.Activity.dispatchTouchEvent(Activity.java:2364) 01-01 03:05:50.050 E/GeckoEvent( 4577): at com.android.internal.policy.impl.PhoneWindow$DecorView.dispatchTouchEvent(PhoneWindow.java:2011) 01-01 03:05:50.050 E/GeckoEvent( 4577): at android.view.View.dispatchPointerEvent(View.java:5876) 01-01 03:05:50.050 E/GeckoEvent( 4577): at android.view.ViewRootImpl.deliverPointerEvent(ViewRootImpl.java:3094) 01-01 03:05:50.050 E/GeckoEvent( 4577): at android.view.ViewRootImpl.handleMessage(ViewRootImpl.java:2614) 01-01 03:05:50.050 E/GeckoEvent( 4577): at android.view.ViewRootImpl.processInputEvents(ViewRootImpl.java:978) 01-01 03:05:50.050 E/GeckoEvent( 4577): at android.view.ViewRootImpl.handleMessage(ViewRootImpl.java:2623) 01-01 03:05:50.050 E/GeckoEvent( 4577): at android.os.Handler.dispatchMessage(Handler.java:99) 01-01 03:05:50.050 E/GeckoEvent( 4577): at android.os.Looper.loop(Looper.java:137) 01-01 03:05:50.050 E/GeckoEvent( 4577): at android.app.ActivityThread.main(ActivityThread.java:4507) 01-01 03:05:50.050 E/GeckoEvent( 4577): at java.lang.reflect.Method.invokeNative(Native Method) 01-01 03:05:50.050 E/GeckoEvent( 4577): at java.lang.reflect.Method.invoke(Method.java:511) 01-01 03:05:50.050 E/GeckoEvent( 4577): at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:790) 01-01 03:05:50.050 E/GeckoEvent( 4577): at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:557) 01-01 03:05:50.050 E/GeckoEvent( 4577): at dalvik.system.NativeStart.main(Native Method)
Kats, anything suspicious above?
Flags: needinfo?(bugmail.mozilla)
Yeah, the first exception in the log is the GeckoEvent.addMotionPoint NPE at 03:02:22.590, and that causes the GeckoTouchEventHandler errors by throwing the touch event sequence out of whack. It sounds like the touch events are triggered before gecko is ready, which doesn't sound possible based on the STR in comment 0.
Flags: needinfo?(bugmail.mozilla)
I think this has the same root cause as bug 876689, which I'll be pushing a patch for in a few minutes. Marking this as a dependency, QA can you please verify?
tracking-fennec: ? → 24+
Depends on: 876689
Needinfo to follow up on Brad's assertion that this is fixed by the bug in comment 5.
Flags: needinfo?(adrian.tamas)
I can confirm that the issue is no longer reproducible on Nightly 24.0a1 2013-06-09 on the Samsung Galaxy S2 (Android 4.0.4) with the "Don't keep activities" option set. Closing as WFM
Status: NEW → RESOLVED
Closed: 11 years ago
Flags: needinfo?(adrian.tamas)
Resolution: --- → WORKSFORME
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: