Closed Bug 878765 Opened 11 years ago Closed 11 years ago

Add missing incrementation in AudioBlockPanStereoToStereo

Categories

(Core :: Web Audio, defect)

Product:
Core
Component:
Web Audio
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED INVALID

People

(Reporter: padenot, Assigned: padenot)

References

Details

Attachments

(1 file, 1 obsolete file)

Add missing incrementation in AudioBlockPanStereoToStereo.
1.17 KB, patch
ehsan.akhgari
: review+
Details | Diff | Splinter Review
No description provided.
Attached patch patch (obsolete) — — Splinter Review
Comment on attachment 757368 [details] [diff] [review] patch Not sure how this went unnoticed for so long. I'll be working on properly testing this node.
Attachment #757368 - Flags: review?(ehsan)
And the same one below.
Attachment #757387 - Flags: review?(ehsan)
Attachment #757368 - Attachment is obsolete: true
Attachment #757368 - Flags: review?(ehsan)
Comment on attachment 757387 [details] [diff] [review] Add missing incrementation in AudioBlockPanStereoToStereo. Review of attachment 757387 [details] [diff] [review]: ----------------------------------------------------------------- Shoot!
Attachment #757387 - Flags: review?(ehsan) → review+
Blink has a number of tests for the panner node. Can you please look into porting them over, or at least writing some of our own? Thanks!
https://hg.mozilla.org/mozilla-central/rev/61862dc749ca
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla24
Component: Video/Audio → Web Audio
Depends on: 880202
Backed out due to bug 880202. https://hg.mozilla.org/integration/mozilla-inbound/rev/dfcabf3d307a
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Target Milestone: mozilla24 → ---
There's no bug here!
Status: REOPENED → RESOLVED
Closed: 11 years ago → 11 years ago
Resolution: --- → INVALID
Depends on: 880845
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: