878765 - Add missing incrementation in AudioBlockPanStereoToStereo

Status: RESOLVED INVALID

(Core :: Web Audio, defect)

Comment 1

[Paul Adenot (:padenot)]

Attachment: patch

Comment 2

[Paul Adenot (:padenot)]

Comment on attachment 757368 [details] [diff] [review]
patch

Not sure how this went unnoticed for so long. I'll be working on properly testing this node.

Comment 3

[Paul Adenot (:padenot)]

Attachment: Add missing incrementation in AudioBlockPanStereoToStereo.

And the same one below.

Comment 4

[(no longer active)]

Comment on attachment 757387 [details] [diff] [review]
Add missing incrementation in AudioBlockPanStereoToStereo.

Review of attachment 757387 [details] [diff] [review]:
-----------------------------------------------------------------

Shoot!

Comment 5

[(no longer active)]

Blink has a number of tests for the panner node.  Can you please look into porting them over, or at least writing some of our own?  Thanks!

Comment 6

[Paul Adenot (:padenot)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/8473deb5fba9

Comment 7

[Paul Adenot (:padenot)]

This got backed out in https://hg.mozilla.org/integration/mozilla-inbound/rev/a2de97d3a53f, relanded in https://hg.mozilla.org/integration/mozilla-inbound/rev/61862dc749ca.

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/61862dc749ca

Comment 9

[Ryan VanderMeulen [:RyanVM]]

Backed out due to bug 880202.
https://hg.mozilla.org/integration/mozilla-inbound/rev/dfcabf3d307a

Comment 10

[(no longer active)]

There's no bug here!