The default bug view has changed. See this FAQ.

in Thunderbird message list context menu, show "Open message in new Tab" above "Open message in new Window"

RESOLVED FIXED in Thunderbird 24.0

Status

Thunderbird
Folder and Message Lists
--
enhancement
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: aceman, Assigned: sshagarwal)

Tracking

Trunk
Thunderbird 24.0

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 3 obsolete attachments)

(Reporter)

Description

4 years ago
In the Thunderbird message list context menu, reorder the items so that "Open message in new Tab" is above "Open message in new Window". Firefox also did this change for links to promote opening in tabs more than windows.
(Assignee)

Comment 1

4 years ago
Created attachment 757546 [details] [diff] [review]
Patch
Attachment #757546 - Flags: ui-review?(bwinton)
Attachment #757546 - Flags: feedback?(acelists)
(Reporter)

Comment 2

4 years ago
Comment on attachment 757546 [details] [diff] [review]
Patch

Looks OK, but what about this: http://mxr.mozilla.org/comm-central/source/mail/base/content/mailWindowOverlay.xul#883 ? I understand that is some other menu, but maybe it would need the treatment too? :)
(Assignee)

Comment 3

4 years ago
Created attachment 757653 [details] [diff] [review]
Patch v2

Made the change for both the menus.
Attachment #757546 - Attachment is obsolete: true
Attachment #757546 - Flags: ui-review?(bwinton)
Attachment #757546 - Flags: feedback?(acelists)
Attachment #757653 - Flags: ui-review?(bwinton)
Attachment #757653 - Flags: feedback?(acelists)
(Reporter)

Comment 4

4 years ago
Comment on attachment 757653 [details] [diff] [review]
Patch v2

Thanks.
Attachment #757653 - Flags: feedback?(acelists) → feedback+
(Assignee)

Updated

4 years ago
Status: NEW → ASSIGNED
Comment on attachment 757653 [details] [diff] [review]
Patch v2

I think the folderContextOpenNewWindow.label should change to "Open in New Window", but other than that (and all the changes that implies), ui-r=me.  :)
Attachment #757653 - Flags: ui-review?(bwinton) → ui-review+
(Assignee)

Comment 6

4 years ago
Created attachment 763583 [details] [diff] [review]
Patch v3
Attachment #757653 - Attachment is obsolete: true
Attachment #763583 - Flags: ui-review+
Attachment #763583 - Flags: feedback?(acelists)
(Reporter)

Comment 7

4 years ago
Comment on attachment 763583 [details] [diff] [review]
Patch v3

Review of attachment 763583 [details] [diff] [review]:
-----------------------------------------------------------------

::: mail/locales/en-US/chrome/messenger/messenger.dtd
@@ +588,1 @@
>  <!ENTITY folderContextOpenNewWindow.accesskey "O">

I think you now also need to change the folderContextOpenNewWindow.accesskey to folderContextOpenInNewWindow.accesskey .
Attachment #763583 - Flags: feedback?(acelists)
(Assignee)

Comment 8

4 years ago
Created attachment 763748 [details] [diff] [review]
Patch v3 (revised)

Sir,

Made the change.
Carrying over ui-r from bwinton.
Attachment #763583 - Attachment is obsolete: true
Attachment #763748 - Flags: ui-review+
Attachment #763748 - Flags: feedback?(acelists)
(Reporter)

Comment 9

4 years ago
Comment on attachment 763748 [details] [diff] [review]
Patch v3 (revised)

Review of attachment 763748 [details] [diff] [review]:
-----------------------------------------------------------------

OK.
Attachment #763748 - Flags: feedback?(acelists) → feedback+
(Assignee)

Updated

4 years ago
Attachment #763748 - Flags: review?(mkmelin+mozilla)

Comment 10

4 years ago
Comment on attachment 763748 [details] [diff] [review]
Patch v3 (revised)

Review of attachment 763748 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good to me! r=mkmelin
Attachment #763748 - Flags: review?(mkmelin+mozilla) → review+
(Assignee)

Updated

4 years ago
Keywords: checkin-needed
https://hg.mozilla.org/comm-central/rev/14619b650793
Status: ASSIGNED → RESOLVED
Last Resolved: 4 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 24.0
You need to log in before you can comment on or make changes to this bug.