Last Comment Bug 878933 - in Thunderbird message list context menu, show "Open message in new Tab" above "Open message in new Window"
: in Thunderbird message list context menu, show "Open message in new Tab" abov...
Status: RESOLVED FIXED
:
Product: Thunderbird
Classification: Client Software
Component: Folder and Message Lists (show other bugs)
: Trunk
: All All
: -- enhancement (vote)
: Thunderbird 24.0
Assigned To: Suyash Agarwal (:sshagarwal)
:
Mentors:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2013-06-03 11:53 PDT by :aceman
Modified: 2013-06-25 05:19 PDT (History)
4 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---


Attachments
Patch (1.94 KB, patch)
2013-06-03 12:27 PDT, Suyash Agarwal (:sshagarwal)
no flags Details | Diff | Splinter Review
Patch v2 (3.50 KB, patch)
2013-06-03 14:57 PDT, Suyash Agarwal (:sshagarwal)
bwinton: ui‑review+
acelists: feedback+
Details | Diff | Splinter Review
Patch v3 (4.49 KB, patch)
2013-06-17 08:38 PDT, Suyash Agarwal (:sshagarwal)
syshagarwal: ui‑review+
Details | Diff | Splinter Review
Patch v3 (revised) (4.59 KB, patch)
2013-06-17 12:54 PDT, Suyash Agarwal (:sshagarwal)
mkmelin+mozilla: review+
syshagarwal: ui‑review+
acelists: feedback+
Details | Diff | Splinter Review

Description :aceman 2013-06-03 11:53:43 PDT
In the Thunderbird message list context menu, reorder the items so that "Open message in new Tab" is above "Open message in new Window". Firefox also did this change for links to promote opening in tabs more than windows.
Comment 1 Suyash Agarwal (:sshagarwal) 2013-06-03 12:27:30 PDT
Created attachment 757546 [details] [diff] [review]
Patch
Comment 2 :aceman 2013-06-03 12:45:01 PDT
Comment on attachment 757546 [details] [diff] [review]
Patch

Looks OK, but what about this: http://mxr.mozilla.org/comm-central/source/mail/base/content/mailWindowOverlay.xul#883 ? I understand that is some other menu, but maybe it would need the treatment too? :)
Comment 3 Suyash Agarwal (:sshagarwal) 2013-06-03 14:57:42 PDT
Created attachment 757653 [details] [diff] [review]
Patch v2

Made the change for both the menus.
Comment 4 :aceman 2013-06-04 00:02:08 PDT
Comment on attachment 757653 [details] [diff] [review]
Patch v2

Thanks.
Comment 5 Blake Winton (:bwinton) (:☕️) 2013-06-16 18:40:20 PDT
Comment on attachment 757653 [details] [diff] [review]
Patch v2

I think the folderContextOpenNewWindow.label should change to "Open in New Window", but other than that (and all the changes that implies), ui-r=me.  :)
Comment 6 Suyash Agarwal (:sshagarwal) 2013-06-17 08:38:37 PDT
Created attachment 763583 [details] [diff] [review]
Patch v3
Comment 7 :aceman 2013-06-17 12:12:35 PDT
Comment on attachment 763583 [details] [diff] [review]
Patch v3

Review of attachment 763583 [details] [diff] [review]:
-----------------------------------------------------------------

::: mail/locales/en-US/chrome/messenger/messenger.dtd
@@ +588,1 @@
>  <!ENTITY folderContextOpenNewWindow.accesskey "O">

I think you now also need to change the folderContextOpenNewWindow.accesskey to folderContextOpenInNewWindow.accesskey .
Comment 8 Suyash Agarwal (:sshagarwal) 2013-06-17 12:54:40 PDT
Created attachment 763748 [details] [diff] [review]
Patch v3 (revised)

Sir,

Made the change.
Carrying over ui-r from bwinton.
Comment 9 :aceman 2013-06-17 13:00:47 PDT
Comment on attachment 763748 [details] [diff] [review]
Patch v3 (revised)

Review of attachment 763748 [details] [diff] [review]:
-----------------------------------------------------------------

OK.
Comment 10 Magnus Melin 2013-06-18 12:19:46 PDT
Comment on attachment 763748 [details] [diff] [review]
Patch v3 (revised)

Review of attachment 763748 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good to me! r=mkmelin
Comment 11 Ryan VanderMeulen [:RyanVM] 2013-06-20 13:50:12 PDT
https://hg.mozilla.org/comm-central/rev/14619b650793

Note You need to log in before you can comment on or make changes to this bug.