879342 - Fix missing icons on some apps

Status: RESOLVED FIXED

(Marketplace Graveyard :: Developer Pages, defect, P2)

Description

[nati]

User Agent: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.31 (KHTML, like Gecko) Chrome/26.0.1410.63 Safari/537.31

Steps to reproduce:

got an app from the API (https://marketplace.firefox.com/api/v1/apps/app/364738/), tried getting the largest icon (128: https://marketplace.cdn.mozilla.net/img/uploads/addon_icons/364/364738-128.png?modified=1359559858)


Actual results:

got '404 Not Found'


Expected results:

I should have got an icon :)

Comment 1

[nati]

This also happens with the following icons:
https://marketplace.cdn.mozilla.net/img/uploads/addon_icons/398/398722-128.png?modified=1357926098
https://marketplace.cdn.mozilla.net/img/uploads/addon_icons/429/429300-128.png?modified=1364786432
https://marketplace.cdn.mozilla.net/img/uploads/addon_icons/436/436868-128.png?modified=1367878835
https://marketplace.cdn.mozilla.net/img/uploads/addon_icons/407/407668-128.png?modified=1359559914
https://marketplace.cdn.mozilla.net/img/uploads/addon_icons/426/426424-128.png?modified=1363112433
https://marketplace.cdn.mozilla.net/img/uploads/addon_icons/418/418800-128.png?modified=1359357633
https://marketplace.cdn.mozilla.net/img/uploads/addon_icons/429/429804-128.png?modified=1369423789
https://marketplace.cdn.mozilla.net/img/uploads/addon_icons/437/437968-128.png?modified=1368444025
https://marketplace.cdn.mozilla.net/img/uploads/addon_icons/370/370541-128.png?modified=1355437278
https://marketplace.cdn.mozilla.net/img/uploads/addon_icons/378/378299-128.png?modified=1359559926
https://marketplace.cdn.mozilla.net/img/uploads/addon_icons/425/425412-128.png?modified=1362616375
https://marketplace.cdn.mozilla.net/img/uploads/addon_icons/367/367324-128.png?modified=1359559891
https://marketplace.cdn.mozilla.net/img/uploads/addon_icons/399/399196-128.png?modified=1363206827
https://marketplace.cdn.mozilla.net/img/uploads/addon_icons/443/443076-128.png?modified=1370092833
https://marketplace.cdn.mozilla.net/img/uploads/addon_icons/365/365999-128.png?modified=1355437286
https://marketplace.cdn.mozilla.net/img/uploads/addon_icons/365/365896-128.png?modified=1359559878
https://marketplace.cdn.mozilla.net/img/uploads/addon_icons/364/364903-128.png?modified=1356211419
https://marketplace.cdn.mozilla.net/img/uploads/addon_icons/364/364754-128.png?modified=1359559866
https://marketplace.cdn.mozilla.net/img/uploads/addon_icons/366/366345-128.png?modified=1359559884
https://marketplace.cdn.mozilla.net/img/uploads/addon_icons/366/366239-128.png?modified=1359559881
https://marketplace.cdn.mozilla.net/img/uploads/addon_icons/366/366111-128.png?modified=1359559879
https://marketplace.cdn.mozilla.net/img/uploads/addon_icons/367/367686-128.png?modified=1355340024
https://marketplace.cdn.mozilla.net/img/uploads/addon_icons/367/367679-128.png?modified=1369401336
https://marketplace.cdn.mozilla.net/img/uploads/addon_icons/368/368172-128.png?modified=1363945551
https://marketplace.cdn.mozilla.net/img/uploads/addon_icons/368/368158-128.png?modified=1359559902
https://marketplace.cdn.mozilla.net/img/uploads/addon_icons/368/368156-128.png?modified=1359559901
https://marketplace.cdn.mozilla.net/img/uploads/addon_icons/366/366461-128.png?modified=1359559889
https://marketplace.cdn.mozilla.net/img/uploads/addon_icons/366/366353-128.png?modified=1359559888
https://marketplace.cdn.mozilla.net/img/uploads/addon_icons/366/366350-128.png?modified=1359559887
https://marketplace.cdn.mozilla.net/img/uploads/addon_icons/364/364941-128.png?modified=1359559875
https://marketplace.cdn.mozilla.net/img/uploads/addon_icons/364/364927-128.png?modified=1361272235
https://marketplace.cdn.mozilla.net/img/uploads/addon_icons/364/364925-128.png?modified=1361272233
https://marketplace.cdn.mozilla.net/img/uploads/addon_icons/364/364714-128.png?modified=1360189535
https://marketplace.cdn.mozilla.net/img/uploads/addon_icons/364/364692-128.png?modified=1360581340
https://marketplace.cdn.mozilla.net/media/img/hub/default-128.png
https://marketplace.cdn.mozilla.net/img/uploads/addon_icons/367/367999-128.png?modified=1360581372
https://marketplace.cdn.mozilla.net/img/uploads/addon_icons/367/367993-128.png?modified=1359559896
https://marketplace.cdn.mozilla.net/img/uploads/addon_icons/367/367990-128.png?modified=1355340025
https://marketplace.cdn.mozilla.net/img/uploads/addon_icons/367/367850-128.png?modified=1361309012
https://marketplace.cdn.mozilla.net/img/uploads/addon_icons/369/369720-128.png?modified=1361318155
https://marketplace.cdn.mozilla.net/img/uploads/addon_icons/369/369395-128.png?modified=1366366825
https://marketplace.cdn.mozilla.net/img/uploads/addon_icons/369/369352-128.png?modified=1360581378
https://marketplace.cdn.mozilla.net/img/uploads/addon_icons/369/369146-128.png?modified=1359559904
https://marketplace.cdn.mozilla.net/img/uploads/addon_icons/364/364741-128.png?modified=1359559859
https://marketplace.cdn.mozilla.net/img/uploads/addon_icons/364/364740-128.png?modified=1355340024
https://marketplace.cdn.mozilla.net/img/uploads/addon_icons/364/364738-128.png?modified=1359559858
https://marketplace.cdn.mozilla.net/img/uploads/addon_icons/364/364736-128.png?modified=1355340024
https://marketplace.cdn.mozilla.net/img/uploads/addon_icons/364/364753-128.png?modified=1355340024
https://marketplace.cdn.mozilla.net/img/uploads/addon_icons/364/364752-128.png?modified=1359559865
https://marketplace.cdn.mozilla.net/img/uploads/addon_icons/364/364751-128.png?modified=1355340024
https://marketplace.cdn.mozilla.net/img/uploads/addon_icons/364/364750-128.png?modified=1359559864
https://marketplace.cdn.mozilla.net/img/uploads/addon_icons/364/364749-128.png?modified=1355340024

Comment 2

[nati]

Apparently some apps have no working icon at all...

bvsg
orionhub-web-development-en
carrier-info
lana-del-rey
rpsls
pojadepl
the-survivors
mileskm
crescendo
scoreboard
coderwall

Comment 3

[Ran Ben Aharon [:ranbena] EverythingMe]

Set it as a blocker for 873167. We're in need of the 11 missing 64 sized icons.
The 128 size is not critical.

Comment 4

[Mathieu Pillard [:mat]]

From my initial testing:

The following apps have issues that need to be fixed by their developers:

- carrier-info: no icons in the zip file (packaged app)
- bvsg: no icons defined in the manifest
- lana-del-rey: manifest validation error: Icon size does not match.
- scoreboard: manifest validation error: Error while requesting icon (x 4)

The following apps are packaged apps; they are missing 64x64 icons in both 
package and manifest, but AFAIK the marketplace should have resized the 128x128
and created a 64x64 version. I think re-uploading those should fix the problem.

- mileskm
- rpsls (note: developer name missing in manifest)

The rest of the apps mentioned in comment 2 are hosted apps that seem to have working icons and seem to be working fine locally. My guess is, these apps didn't have working icons originally, and we don't seem to be re-fetching icons ever, so when they eventually do fix
that it's too late. I'll file a separate bug for this.

Comment 5

[Mathieu Pillard [:mat]]

I've been checking the reported missing 128 icons and the results are similar: excluding those already mentioned in previous comment, a few have manifest validation errors, but most have working icons that I can import without any trouble locally.

Implementing bug 883289 and triggering a manifest/icon refresh manually for those apps should fix the problem regardless of the missing size.

Comment 6

[Mathieu Pillard [:mat]]

bug 883289 is about the long-term fix. Short-term, I'll write a simpler task for this bug that just fixes missing icons for specified apps.

Comment 7

[Mathieu Pillard [:mat]]

Task committed in https://github.com/mozilla/zamboni/commit/807b279e0603c593ac62ce68e8c2634d35bf91d3

Now we need to wait for next push and run it, it should solve the problem for those apps.

Comment 8

[krupa raj[:krupa]]

Have we run this in dev yet? I don't see the icon at https://marketplace-dev.allizom.org/app/lana-del-rey?src=search

Comment 9

[Mathieu Pillard [:mat]]

krupa: I don't remember, but we can run it again, it doesn't hurt. However, per comment #4, that won't fix this particular app because there was a problem with their manifest.

Comment 10

[Mathieu Pillard [:mat]]

We ran the script in production, I see most icons are fixed. I assume the remaining ones are missing in the manifest itself or things like that and we can't do much about them. If there are still missing icons for a particular app that has a valid manifest & icons, please re-open this bug.