Closed Bug 879685 (mmi-localization-cw) Opened 7 years ago Closed 7 years ago

[MMI] Localization of Call Waiting functionality.

Categories

(Firefox OS Graveyard :: Gaia::Dialer, defect)

ARM
Gonk (Firefox OS)
defect
Not set
normal

Tracking

(blocking-b2g:leo+, b2g18 fixed, b2g-v1.1hd fixed)

RESOLVED FIXED
1.1 QE3 (26jun)
blocking-b2g leo+
Tracking Status
b2g18 --- fixed
b2g-v1.1hd --- fixed

People

(Reporter: bov, Assigned: ferjm)

References

Details

(Keywords: late-l10n, Whiteboard: [mozilla-triage])

Attachments

(3 files)

Steps    
- Settings, Language, Set to any language except english    
- Open Dialer App, type "*43#, and click on the green dialer button

Actual Result:
Tested on Unagi device. Build :Gecko-52341e4.Gaia-71c3bcd CommRIL:AU105
Result:"Call waiting Service was enabled"
The CSS works but the returned message is in english

Tested on Unagi device. Build :Gecko-80fd2ae.Gaia-0a1cf9f CommRIL:AU115
Result:"CALL_WAITING_NOT_SUPPORTED_VIA_MMI"
The CSS doesn't work and the returned error message is in english

Expected Result:
The error message should be shown in the selected language in Settings
Expected Result:
Both, confirmation and error messages should be shown in english
Blocks: 879750
These look like issues partners will care about having fixed for releasing in target markets - Michael seems related to 879032 - thoughts?
Flags: needinfo?(mvines)
Whiteboard: [mozilla-triage]
Flags: needinfo?(mvines)
Flags: needinfo?(anshulj)
Depends on: 879032
Flags: needinfo?(anshulj)
Assignee: nobody → cyang
Partner think it's a blocker
blocking-b2g: leo? → leo+
Assignee: cyang → ferjmoreno
Alias: mmi-localization-cw
Summary: [Supplementary Service][Call Waiting][COMMERCIAL RIL] Call Waiting SS error responses are shown in English when selected language is other → [MMI] Localization of Call Waiting functionality.
Depends on: 883178
No longer blocks: 879750
Duplicate of this bug: 873999
Blocks: 879750
Keywords: late-l10n
Target Milestone: --- → 1.1 QE3 (24jun)
Carol, as in https://bugzilla.mozilla.org/show_bug.cgi?id=879694#c4 , could you do the same for Call Waiting, please? Thanks a lot! :)
Flags: needinfo?(cyang)
(In reply to Fernando Jiménez Moreno [:ferjm] (needinfo instead of CC, please) from comment #5)
> Carol, as in https://bugzilla.mozilla.org/show_bug.cgi?id=879694#c4 , could
> you do the same for Call Waiting, please? Thanks a lot! :)

Hi Fernando, the replies are the same as what I listed at https://bugzilla.mozilla.org/show_bug.cgi?id=879694#c5 with the exception that mmiServiceCode should be 'scCallWaiting' instead.
Flags: needinfo?(cyang)
Attached patch v1Splinter Review
This one was easy :)
Attachment #768848 - Flags: review?(anthony)
Attachment #768848 - Flags: review?(anthony) → review+
And the review was easy too ;)
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Uplifted 6fb3fbd87edbbb1740a9755b75750ffb9aa982e8 to:
v1-train: 42ac68c8bf09c218bcfec520bc0261721ff2932c
v1.1.0hd: 42ac68c8bf09c218bcfec520bc0261721ff2932c
Tested on unagi-ICS.user.manifest.V1-train.Rel0.4.Sprint12.B-333.Gecko-0441a31.Gaia-6c635e8
Build Id: 20130731102508

BOTH Reference RIL and Commercial RIL AU172

Steps    
- Settings, Language, Set to any language except english    
- Open Dialer App, type "*43#, and click on the green dialer button

The CSS doesn' work ("Invalid or Unsupported MMI Code")although the returned message is in the selected language in Settings

See attachments Test 879685_1.png and Test 879685_2.png

So , the translation is OK but the Call Waiting Service is not supported. Should I open a new bug or track any other that already exists?
Flags: needinfo?(ferjmoreno)
Flags: needinfo?(cyang)
Attached image Test 879685_1
Attached image Test 879685_2
I can't reproduce this issue on AU172 or newer builds (in English or another language). Can you please provide logcat using |adb logcat -vthreadtime -b main -b radio|?
Flags: needinfo?(cyang) → needinfo?(bov)
Testing on unagi-ICS.user.manifest.V1-train.Rel0.4.Sprint12.B-335.Gecko-33ad8a4.Gaia-6e298d9
Build id: 20130801101003
Platform: 18.1
Commercial RIL: AU 179

Now, every Call Waiting code (*43#, *#43#, #43#) is working fine. 
And the translation is correct in every language selected (tested in English, French, Portuguese and Spanish)
*43#: "Service was enabled"
*#43#: "Service enabled for: Voice..."
#43#:: "Service has been disabled"
Except the *43# code in Spanish, that returns "The service was disabled" instead of "Service was enabled" (in Spanish, of course)
Do you still need the logcat?
Thanks!
Flags: needinfo?(bov) → needinfo?(cyang)
I no longer need logcat. If *43# is returning the wrong string in Spanish only, then there may have been a translation error during the l10n work.
Flags: needinfo?(cyang)
All strings appear for both Serbian and Serbian-Latin when the user enters any one of the three call waiting codes listed in Comment 16

Environmental Variables
Build ID: 20130814041202
Gecko: http://hg.mozilla.org/releases/mozilla-b2g18/rev/15813d776a69
Gaia: dd3959fa74e356a528daa76ffee14c2c728a4b56
Platform Version: 18.1
RIL Version: 01.01.00.019.190 
Firmware- D300f08o
Flags: needinfo?(mdinic)
It seems that you don't need any other info from me as this looks like a translation issue, so I'm clearing the needinfo flag. Feel free to set it back if that changes, please :)
Flags: needinfo?(ferjmoreno)
Flags: needinfo?(mdinic) → needinfo?(milos)
This is fixed for Serbian in http://hg.mozilla.org/gaia-l10n/sr-Cyrl/rev/6ac37e83d222
Flags: needinfo?(milos)
You need to log in before you can comment on or make changes to this bug.