87970 - selecting entry from location history should move entry to top

Status: RESOLVED FIXED

(SeaMonkey :: Location Bar, defect, P4)

Description

[Jeremy M. Dolan]

This has always annoyed me in Netscape and IE. Selecting an item from the
location bar history drop down should move the entry to the top of the history,
so it won't expire as soon. Also, it keeps them in a more logical chronological
order. Also, if a user selects an entry once, they are more likely to select the
same one again, so moving it to the top removed the need to scroll all the way
down and find it again (my major annoyance with this).

Comment 1

[Radha on family leave (not reading bugmail)]

This is urlbar history not session History. 

Comment 2

[Jeremy M. Dolan]

Switching component per comment.

Is this by chance a quick fix that can be done?

Comment 3

[timeless]

i doubt it

Comment 4

[Blake Ross]

Joe was dying to have these bugs. Who am I to say no?

Comment 5

[Joe Hewitt (gone)]

*** Bug 69265 has been marked as a duplicate of this bug. ***

Comment 6

[Andriy Gapon]

maybe this quick fix would fly ? I'm not saying it's good, but it's really quick
and does the job.

--- xpfe/browser/resources/content/sessionHistoryUI.js.orig     Mon Jan 14
22:21:44 2002
+++ xpfe/browser/resources/content/sessionHistoryUI.js  Mon Jan 14 22:22:39 2002
@@ -101,6 +101,9 @@
         var uri = getShortcutOrURI(label);
         if (gURLBar) {
           gURLBar.value = uri;
+          //avg -- am I right or am I rite :)
+          //this will find url among existing ones and propagate it to the top
+          addToUrlbarHistory();
           BrowserLoadURL();
         }
         else

of course it's really unnecessary to keep my comments in the main source.

Comment 7

[Andriy Gapon]

by the way, patch in the previous comment is against 0.9.7 sources

Comment 8

[Andriy Gapon]

Attachment: patch for promoting selected url to the top of url-bar history

this is a patch for executeUrlBarHistoryCommand() function, when this function
is invoked it will also call addToUrlbarHistory() that will effectively move
selected entry from its current position to the top of the list

Comment 9

[Radha on family leave (not reading bugmail)]

The patch looks good to me. However, I'm not the official owner of the code.
blaker or jag can official put the review comments. 

Comment 10

[Andriy Gapon]

do you mean these guys: [e-mail] and [e-mail] or
somebody else ?

Comment 11

[Jeremy M. Dolan]

Whoo hooo... Ukraine coming through with the patch! Neat fix... jag, blake...
radha says you're the men for reviews... does this work?

Comment 12

[jag (Peter Annema)]

Comment on attachment 69153 [details] [diff] [review]
patch for promoting selected url to the top of url-bar history

r=/sr=jag

Comment 13

[Mike Shaver (:shaver emeritus)]

Comment on attachment 69153 [details] [diff] [review]
patch for promoting selected url to the top of url-bar history

Looks fine. sr=shaver.

Comment 14

[Alfonso Martinez]

*** Bug 125960 has been marked as a duplicate of this bug. ***

Comment 15

[Blake Ross]

Checked this patch in.

Comment 16

[Jeremy M. Dolan]

One minor issue. It seems to be retroactive...it moves to the top of the list
whatever final URL ends up there.

I have a 'g' custom keyword for google. If I select "g foobar" from the URL bar
from down, it adds a new entry to the top of this list:

  google.com/search?q=foobar

And "g foobar" remains where it was (well, it's pushed down one, but...)