879938 - Remove Lookup methods and Xpath elements from lib/prefs.js

Status: RESOLVED WONTFIX

(Mozilla QA Graveyard :: Mozmill Tests, defect)

Description

[Jonathan French (:jfrench)]

Split off from bug 503192, this is a marker bug to remove and replace any elementslib.Lookup methods and Xpath elements from lib/prefs.js to make the code base less fragile. We would like to replace Lookup with ID, Selector, or if neither work, Class via NodeCollector.

An example of this approach can be found here in the getElements() method in lib/addons.js
http://hg.mozilla.org/qa/mozmill-tests/file/b8a22c8c9a3b/lib/addons.js#l1026

Comment 1

[Amod [:AMoz]]

I would like to work on this bug. I would upload the patch within a while.

Comment 2

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Amod, I would suggest that you are getting started with a single bug like bug 879884 first. Once done or nearly finished we could assign additionally bugs to you. Would that work?

Comment 3

[Amod [:AMoz]]

sure...no problem..

Comment 4

[Amod [:AMoz]]

since the bug 879884 is resolved I self-assign this bug and start working on it.

Comment 5

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Sounds like a good starter for you indeed. Let us know if you have questions.

Comment 6

[Amod [:AMoz]]

(In reply to Jonathan French (:jfrench) from comment #0)
> An example of this approach can be found here in the getElements() method in
> lib/addons.js
> http://hg.mozilla.org/qa/mozmill-tests/file/b8a22c8c9a3b/lib/addons.js#l1026

In this case, would it be correct to define | parent | as done in 
http://hg.mozilla.org/qa/mozmill-tests/file/b8a22c8c9a3b/lib/addons.js#l1035
http://hg.mozilla.org/qa/mozmill-tests/file/b8a22c8c9a3b/lib/addons.js#l1046
http://hg.mozilla.org/qa/mozmill-tests/file/b8a22c8c9a3b/lib/addons.js#l1048

Comment 7

[Henrik Skupin [:whimboo][⌚️UTC+2]]

You might wanna take the same set of parameters, and make use them as needed. First you might want to check which elements to modify and how best they are reachable. If you have to use the nodeCollector it would be wise to implement it similar to the addons.js module.

Comment 8

[Henrik Skupin [:whimboo][⌚️UTC+2]]

I will put this bug back into the general bucket, so we can find someone who want to fix it in a short term. Would be good to get this done soon.

Comment 9

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Since the last update on this bug the Mozmill tests have been deprecated in
favor of the Firefox UI tests. So we no longer want to fix this bug.