Closed Bug 880104 Opened 7 years ago Closed 7 years ago

Remove -moz prefixed style from flexbox tests, to make them more suitable for w3c testsuite & other browser vendors to run

Categories

(Core :: Layout, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla24

People

(Reporter: dholbert, Assigned: dholbert)

References

Details

Attachments

(4 files)

Filing this bug on removing some -moz prefixed styles (e.g. "-moz-max-content") from our flexbox reftests, so that other browsers have a shot at rendering them and so that they're more suitable for submission to the w3c.
Depends on: css3-flexbox
Assignee: nobody → dholbert
Status: NEW → ASSIGNED
OS: Linux → All
The flexbox-align-self-* reftests (reference cases in particular) use intrinsic sizing keywords a lot, to shrinkwrap chunks of text.

This patch tweaks these tests to use floats and/or inline-blocks instead of intrinsic sizing keywords (and does a bit of other cleanup while I'm at it).
Attachment #758987 - Attachment description: part 2: replace some width keywords with exact pixel values → part 2: replace some -moz prefixed sizing keywords with their already-known exact pixel values
This patch uses the same text-align:center + inline-block technique used in part 1, for centering shrinkwrapped content, now in flexbox-justify-content-horiz-5-ref.xhtml. (plus some other cleanup / simplification in that test)
This part removes an unnecessary (on my machine at least) intrinsic sizing keyword from flexbox-widget-flex-items-4.html, and does a bit of other minor cleanup there (making the testcase and reference case align slightly better, property-ordering-wise).
Try run: https://tbpl.mozilla.org/?tree=Try&rev=03896438777e

dbaron rubber-stamped the general idea of this bug, so assuming the Try run succeeds, I'll go ahead and land this.
(In reply to Daniel Holbert [:dholbert] from comment #5)
> dbaron rubber-stamped the general idea of this bug,

(in IRC)
Blocks: 880137
Apparently the simplification to flexbox-align-self-vert-rtl-1-ref.xhtml made it fail on Android, with a single letter in "unspec" being off by one pixel (or maybe less) -- the middle "s". Sample log:
 https://tbpl.mozilla.org/php/getParsedLog.php?id=23849919&tree=Mozilla-Inbound

I just pushed a followup to annotate that test as having 32 fuzzy pixels on Android.
  https://hg.mozilla.org/integration/mozilla-inbound/rev/0972920ff3be
(In reply to Daniel Holbert [:dholbert] (traveling June 7-12, w/ mixed availability) from comment #8)
> Apparently the simplification to flexbox-align-self-vert-rtl-1-ref.xhtml
> made it fail on Android, with a single letter in "unspec" being off by one
> pixel (or maybe less) -- the middle "s". Sample log:
>  https://tbpl.mozilla.org/php/getParsedLog.php?id=23849919&tree=Mozilla-
> Inbound
> 
> I just pushed a followup to annotate that test as having 32 fuzzy pixels on
> Android.
>   https://hg.mozilla.org/integration/mozilla-inbound/rev/0972920ff3be

That makes it seem like the centering methods used in test and reference round differently.  It might be worth investigating.
You need to log in before you can comment on or make changes to this bug.